From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED23CCA9EB7 for ; Tue, 22 Oct 2019 04:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C469B21783 for ; Tue, 22 Oct 2019 04:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731029AbfJVEe4 (ORCPT ); Tue, 22 Oct 2019 00:34:56 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:59970 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbfJVEe4 (ORCPT ); Tue, 22 Oct 2019 00:34:56 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMlsh-0008Bu-VQ; Tue, 22 Oct 2019 04:34:52 +0000 Date: Tue, 22 Oct 2019 05:34:51 +0100 From: Al Viro To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, y2038@lists.linaro.org, linux-fsdevel@vger.kernel.org, Greg Kroah-Hartman , "Michael S . Tsirkin" , "David S . Miller" , Jarkko Sakkinen , Jason Gunthorpe , Jiri Kosina , Stefan Hajnoczi , Cornelia Huck Subject: Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl Message-ID: <20191022043451.GB20354@ZenIV.linux.org.uk> References: <20191009190853.245077-1-arnd@arndb.de> <20191009191044.308087-11-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009191044.308087-11-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. I'd rather flipped your #7 (ceph_compat_ioctl() introduction) past that one...