From: Matthew Wilcox <willy@infradead.org>
To: "Schumaker, Anna" <Anna.Schumaker@netapp.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"mbenjami@redhat.com" <mbenjami@redhat.com>,
"boaz@plexistor.com" <boaz@plexistor.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"mszeredi@redhat.com" <mszeredi@redhat.com>,
"amir73il@gmail.com" <amir73il@gmail.com>,
"Manole, Sagi" <Sagi.Manole@netapp.com>
Subject: Re: [PATCH 11/16] zuf: Write/Read implementation
Date: Tue, 29 Oct 2019 13:15:21 -0700 [thread overview]
Message-ID: <20191029201521.GC17669@bombadil.infradead.org> (raw)
In-Reply-To: <db90d73233484d251755c5a0cb7ee570b3fc9d19.camel@netapp.com>
On Tue, Oct 29, 2019 at 08:08:16PM +0000, Schumaker, Anna wrote:
> > + return size ?: ret;
>
> It looks like you're returning "ret" if the ternary evaluates to false, but it's not clear to
> me what is returned if it evaluates to true. It's possible it's okay, but I just don't know
> enough about how ternaries work in this case.
It's an unloved, unwnted GNU extension. See
https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html
It's really no better than writing:
return size ? size : ret;
or even better:
if (size)
return size;
return ret;
next prev parent reply other threads:[~2019-10-29 20:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 2:07 [PATCHSET v02 00/16] zuf: ZUFS Zero-copy User-mode FileSystem Boaz Harrosh
2019-09-26 2:07 ` [PATCH 01/16] fs: Add the ZUF filesystem to the build + License Boaz Harrosh
2019-09-26 2:07 ` [PATCH 02/16] MAINTAINERS: Add the ZUFS maintainership Boaz Harrosh
2019-09-26 2:07 ` [PATCH 03/16] zuf: Preliminary Documentation Boaz Harrosh
2019-09-26 2:07 ` [PATCH 04/16] zuf: zuf-rootfs Boaz Harrosh
2019-09-26 2:07 ` [PATCH 05/16] zuf: zuf-core The ZTs Boaz Harrosh
2019-09-26 2:07 ` [PATCH 06/16] zuf: Multy Devices Boaz Harrosh
2019-09-26 2:07 ` [PATCH 07/16] zuf: mounting Boaz Harrosh
2019-09-26 2:07 ` [PATCH 08/16] zuf: Namei and directory operations Boaz Harrosh
2019-09-26 2:07 ` [PATCH 09/16] zuf: readdir operation Boaz Harrosh
2019-09-26 2:07 ` [PATCH 10/16] zuf: symlink Boaz Harrosh
2019-09-26 2:07 ` [PATCH 11/16] zuf: Write/Read implementation Boaz Harrosh
[not found] ` <db90d73233484d251755c5a0cb7ee570b3fc9d19.camel@netapp.com>
2019-10-29 20:15 ` Matthew Wilcox [this message]
2019-11-14 14:04 ` Boaz Harrosh
2019-11-14 15:15 ` Boaz Harrosh
2019-11-14 16:08 ` Schumaker, Anna
2019-09-26 2:07 ` [PATCH 12/16] zuf: mmap & sync Boaz Harrosh
2019-09-26 2:07 ` [PATCH 13/16] zuf: More file operation Boaz Harrosh
2019-09-26 2:07 ` [PATCH 14/16] zuf: ioctl implementation Boaz Harrosh
2019-09-26 2:07 ` [PATCH 15/16] zuf: xattr && acl implementation Boaz Harrosh
2019-09-26 2:07 ` [PATCH 16/16] zuf: Support for dynamic-debug of zusFSs Boaz Harrosh
2019-09-26 7:11 ` [PATCHSET v02 00/16] zuf: ZUFS Zero-copy User-mode FileSystem Miklos Szeredi
2019-09-26 9:41 ` Bernd Schubert
2019-09-26 11:27 ` Boaz Harrosh
2019-09-26 12:12 ` Bernd Schubert
2019-09-26 12:24 ` Boaz Harrosh
2019-09-26 13:45 ` Miklos Szeredi
2019-09-26 12:48 ` Boaz Harrosh
2019-09-26 13:48 ` Miklos Szeredi
2019-09-26 11:41 ` Boaz Harrosh
-- strict thread matches above, loose matches on Subject: below --
2019-08-12 16:47 [PATCHSET " Boaz Harrosh
2019-08-12 16:48 ` [PATCH 11/16] zuf: Write/Read implementation Boaz Harrosh
2019-08-12 16:42 [PATCHSET 00/16] zuf: ZUFS Zero-copy User-mode FileSystem Boaz Harrosh
2019-08-12 16:42 ` [PATCH 11/16] zuf: Write/Read implementation Boaz Harrosh
2019-08-13 10:23 ` kbuild test robot
2019-08-13 10:28 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029201521.GC17669@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Sagi.Manole@netapp.com \
--cc=amir73il@gmail.com \
--cc=boaz@plexistor.com \
--cc=dan.j.williams@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbenjami@redhat.com \
--cc=mszeredi@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).