From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5A4C5DF60 for ; Thu, 7 Nov 2019 08:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D107421D79 for ; Thu, 7 Nov 2019 08:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733270AbfKGInU (ORCPT ); Thu, 7 Nov 2019 03:43:20 -0500 Received: from verein.lst.de ([213.95.11.211]:55785 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727120AbfKGInU (ORCPT ); Thu, 7 Nov 2019 03:43:20 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id C022A68CEC; Thu, 7 Nov 2019 09:43:17 +0100 (CET) Date: Thu, 7 Nov 2019 09:43:16 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH] fs: Fix overflow in block_page_mkwrite Message-ID: <20191107084316.GA9895@lst.de> References: <20191106190239.20860-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106190239.20860-1-agruenba@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Nov 06, 2019 at 08:02:39PM +0100, Andreas Gruenbacher wrote: > On architectures where ssize_t is wider than pgoff_t, the expression > ((page->index + 1) << PAGE_SHIFT) can overflow. Rewrite to use the page > offset, which we already compute here anyway. Looks good modulo the s/ssize_t/loff_t/ mentioned in the other patch: Reviewed-by: Christoph Hellwig