From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: linux-xfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] iomap: Fix overflow in iomap_page_mkwrite
Date: Thu, 7 Nov 2019 07:37:32 -0800 [thread overview]
Message-ID: <20191107153732.GA6211@magnolia> (raw)
In-Reply-To: <CAHc6FU4BXZ7fiLa_tVhZWZmqoXNCJWQwUvb7UPzGrWt_ZBBvxQ@mail.gmail.com>
On Wed, Nov 06, 2019 at 08:34:26PM +0100, Andreas Gruenbacher wrote:
> On Wed, Nov 6, 2019 at 8:17 PM Darrick J. Wong <darrick.wong@oracle.com> wrote:
> > On Wed, Nov 06, 2019 at 08:04:00PM +0100, Andreas Gruenbacher wrote:
> > > On architectures where ssize_t is wider than pgoff_t, the expression
> >
> > ssize_t? But you're changing @offset, which is loff_t. I'm confused.
>
> Oops, should have been loff_t instead of ssize_t.
I'll fix it on commit.
> > Also, which architectures are you talking about here?
>
> From the kernel headers:
>
> #define pgoff_t unsigned long
> typedef long long __kernel_loff_t;
> typedef __kernel_loff_t loff_t;
>
> So for example, sizeof(loff_t) > sizeof(pgoff_t) on x86.
Ok, that's what I thought.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> Thanks,
> Andreas
>
next prev parent reply other threads:[~2019-11-07 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 19:04 [PATCH] iomap: Fix overflow in iomap_page_mkwrite Andreas Gruenbacher
2019-11-06 19:16 ` Darrick J. Wong
2019-11-06 19:34 ` Andreas Gruenbacher
2019-11-07 15:37 ` Darrick J. Wong [this message]
2019-11-07 17:54 ` Andreas Gruenbacher
2019-11-07 8:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107153732.GA6211@magnolia \
--to=darrick.wong@oracle.com \
--cc=agruenba@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).