From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] ovl: fix timestamp limits
Date: Mon, 11 Nov 2019 09:30:00 +0200 [thread overview]
Message-ID: <20191111073000.2957-1-amir73il@gmail.com> (raw)
Overlayfs timestamp overflow limits should be inherrited from upper
filesystem.
The current behavior, when overlayfs is over an underlying filesystem
that does not support post 2038 timestamps (e.g. xfs), is that overlayfs
overflows post 2038 timestamps instead of clamping them.
This change fixes xfstest generic/402 (verify filesystem timestamps for
supported ranges).
Cc: Deepa Dinamani <deepa.kernel@gmail.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
(*) generic/402 currently does 'notrun' on overlayfs and need
a small fix that I will post shortly
fs/overlayfs/super.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 5d4faab57ba0..44915874fccb 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1621,6 +1621,8 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
sb->s_stack_depth = ofs->upper_mnt->mnt_sb->s_stack_depth;
sb->s_time_gran = ofs->upper_mnt->mnt_sb->s_time_gran;
+ sb->s_time_min = ofs->upper_mnt->mnt_sb->s_time_min;
+ sb->s_time_max = ofs->upper_mnt->mnt_sb->s_time_max;
}
oe = ovl_get_lowerstack(sb, ofs);
--
2.17.1
next reply other threads:[~2019-11-11 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 7:30 Amir Goldstein [this message]
2019-11-11 22:31 ` [PATCH] ovl: fix timestamp limits Deepa Dinamani
2019-11-12 15:48 ` Miklos Szeredi
2019-11-12 16:06 ` Amir Goldstein
2019-11-12 16:45 ` Deepa Dinamani
2019-11-12 16:49 ` Amir Goldstein
2019-11-12 16:56 ` Deepa Dinamani
2019-11-13 10:26 ` Miklos Szeredi
2019-11-13 11:26 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111073000.2957-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=deepa.kernel@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).