From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B3EC432C0 for ; Mon, 25 Nov 2019 09:15:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78D8C2082F for ; Mon, 25 Nov 2019 09:15:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="A8kCdasR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbfKYJPE (ORCPT ); Mon, 25 Nov 2019 04:15:04 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:40397 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726498AbfKYJPD (ORCPT ); Mon, 25 Nov 2019 04:15:03 -0500 Received: by mail-lj1-f195.google.com with SMTP id q2so14920161ljg.7 for ; Mon, 25 Nov 2019 01:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FcfAwDLFSNgmDLyFmP3mnRn5XPVP/dHuo5ueDN07hL8=; b=A8kCdasRJZBhUbUFtfqb5rMrJhY6qNfcEijrrxgkjPoeUE5M2cQ/cSebh/iOdguAYB 8wSrm2cFQTzJbET8njVhqjivMpt+smTtDA5bfSKYqOsNdUkqXz4lolnMUheJjAnf5LVd j0Sz0rfYd1faPSXbjyizjLxqyTGe6WcM6s+e1UpALYOVJOBwZKHlG/jasxCvLaZTK2Po p+xbhoGkmYrAbHynoCLWeYk0/ZzQF/eOXjTVawRfbWB07ciCticc+gPdgP9yG2WPcs2y /6FfE7UxlgQH4+5R/939uPj/IcpEYlo57sLeQW3AgAJH+dEYhDkhPo6LCuwUQmnkHDps lOkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FcfAwDLFSNgmDLyFmP3mnRn5XPVP/dHuo5ueDN07hL8=; b=T9+lzI8hyRgtlItF9XorXQEaamp9FXrNy/x6EEvtL+J5m29ALALIe2ULEHoSwzsx4S BvFE19ICp1IKn10Q7s5jmo7BppkhMfj9TdIZHweLQpjAmU3M66vWOV9QhodvwB/vP3Qs BW887TP8cc6WydLxmVe77JEPAxJ/X8jHUaaQ3uzLrOLUmqHnaHluCkPY5lFWxQsy2B2C ci5kOSbXuf0IBGlEapV9JPn2v27fYVD4+y53PVErJxuGRJrXjvU3w+1bwwlDyNmabo1Q p1PGN9J+PVO+qh6ijdC56V8g7dUL+JVoRRXAn0NPJm0f+f2moMiIxS1rtNs74Ul84rKZ AE1g== X-Gm-Message-State: APjAAAVWtlvkRvNrF84cJ78g+l1hP5qbnbQk+t2zIpTPmt+kzw3lp83J 8LP/6x0Q38LLB7ioulRVk0C1YQ== X-Google-Smtp-Source: APXvYqx3omxBvBBPAeuC2qvJocDKxfyY/bfPA/SuPulk3OiGBBrujyPNMsYgSAQTEVKepMR1D/JfQg== X-Received: by 2002:a2e:9695:: with SMTP id q21mr20770656lji.206.1574673300853; Mon, 25 Nov 2019 01:15:00 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id q21sm3267727lfo.4.2019.11.25.01.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2019 01:14:59 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id CA1C11032C4; Mon, 25 Nov 2019 12:15:08 +0300 (+03) Date: Mon, 25 Nov 2019 12:15:08 +0300 From: "Kirill A. Shutemov" To: Andreas Gruenbacher Cc: Linus Torvalds , Steven Whitehouse , Konstantin Khlebnikov , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexander Viro , Johannes Weiner , cluster-devel@redhat.com, Ronnie Sahlberg , Steve French , Bob Peterson Subject: Re: [RFC PATCH 3/3] gfs2: Rework read and page fault locking Message-ID: <20191125091508.3265wtfzpoupv2lj@box> References: <20191122235324.17245-1-agruenba@redhat.com> <20191122235324.17245-4-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191122235324.17245-4-agruenba@redhat.com> User-Agent: NeoMutt/20180716 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Nov 23, 2019 at 12:53:24AM +0100, Andreas Gruenbacher wrote: > @@ -778,15 +804,51 @@ static ssize_t gfs2_file_direct_write(struct kiocb *iocb, struct iov_iter *from) > > static ssize_t gfs2_file_read_iter(struct kiocb *iocb, struct iov_iter *to) > { > + struct gfs2_inode *ip; > + struct gfs2_holder gh; > + size_t written = 0; 'written' in a read routine? -- Kirill A. Shutemov