From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE058C432C0 for ; Tue, 26 Nov 2019 16:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BBBB2075C for ; Tue, 26 Nov 2019 16:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726180AbfKZQVW (ORCPT ); Tue, 26 Nov 2019 11:21:22 -0500 Received: from verein.lst.de ([213.95.11.211]:41504 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbfKZQVV (ORCPT ); Tue, 26 Nov 2019 11:21:21 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D013468C4E; Tue, 26 Nov 2019 17:21:19 +0100 (CET) Date: Tue, 26 Nov 2019 17:21:19 +0100 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH TRIVIAL] iomap: remove unneeded variable in iomap_dio_rw() Message-ID: <20191126162119.GA7562@lst.de> References: <20191126122051.6041-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191126122051.6041-1-jthumshirn@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Nov 26, 2019 at 01:20:51PM +0100, Johannes Thumshirn wrote: > The 'start' variable indicates the start of a filemap and is set to the > iocb's position, which we have already cached as 'pos', upon function > entry. > > 'pos' is used as a cursor indicating the current position and updated > later in iomap_dio_rw(), but not before the last use of 'start'. > > Remove 'start' as it's synonym for 'pos' before we're entering the loop > calling iomapp_apply(). > > Signed-off-by: Johannes Thumshirn Looks good, Reviewed-by: Christoph Hellwig