From: Matthew Wilcox <willy@infradead.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Eric Biggers <ebiggers@kernel.org>,
Tyler Hicks <tyhicks@canonical.com>,
linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-fscrypt@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup
Date: Tue, 3 Dec 2019 05:56:51 -0800 [thread overview]
Message-ID: <20191203135651.GU20752@bombadil.infradead.org> (raw)
In-Reply-To: <1575377810-3574-1-git-send-email-yangtiezhu@loongson.cn>
On Tue, Dec 03, 2019 at 08:56:50PM +0800, Tiezhu Yang wrote:
> There exists many similar and duplicate codes to check "." and "..",
> so introduce is_dot_dotdot helper to make the code more clean.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>
> v2:
> - use the better performance implementation of is_dot_dotdot
> - make it static inline and move it to include/linux/fs.h
Ugh, not more crap in fs.h.
$ ls -l --sort=size include/linux |head
-rw-r--r-- 1 willy willy 154148 Nov 29 22:35 netdevice.h
-rw-r--r-- 1 willy willy 130488 Nov 29 22:35 skbuff.h
-rw-r--r-- 1 willy willy 123540 Nov 29 22:35 pci_ids.h
-rw-r--r-- 1 willy willy 118991 Nov 29 22:35 fs.h
I think this probably fits well in namei.h. And I think it works
better with bare 'name' and 'len' arguments, rather than taking a qstr.
And, as I asked twice in the last round of review, did you benchmark
this change?
next prev parent reply other threads:[~2019-12-03 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 12:56 [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup Tiezhu Yang
2019-12-03 13:56 ` Matthew Wilcox [this message]
2019-12-05 0:56 ` Tiezhu Yang
2019-12-05 7:06 ` Matthew Wilcox
2019-12-05 7:55 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203135651.GU20752@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=ebiggers@kernel.org \
--cc=ecryptfs@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yangtiezhu@loongson.cn \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).