From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6853C2D0C9 for ; Fri, 13 Dec 2019 04:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CB6C2253D for ; Fri, 13 Dec 2019 04:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="nzq6I9eP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731746AbfLMEKs (ORCPT ); Thu, 12 Dec 2019 23:10:48 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:11856 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727299AbfLMEKq (ORCPT ); Thu, 12 Dec 2019 23:10:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1576210246; x=1607746246; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nRaA3JRYzcP6k4TuIo2+r6HiEqDsmoiNiX7kFHYjflM=; b=nzq6I9ePgZIQpx07M/eAACSO7Ftn/VpTfxRbnYUF3FfziaVPNv4QJYVn f+VnwUSL6Oq9nd5iEpbhtRrOqGxBCMYuSweOpn+ALRwipgskM5Hr0bsfC BBNcjbc/3eT1rKhwF6hQ/iVoWT0eZ9w/3RUtKqh28odINhSGYAjmYp2yG VVBnXjugqJSwTJYiG0lV8q8gEKa278VRu4JBwymLgD4W7lMQCqOJgC8KK PlRaY3QH5jQoR76CB7xS6lDsFMwj7wm9P/ZfuWCyrV3bPvf6XN+MMl5Cw FiHSwObjnVZK2JkX4mEgtQkDG6YFCqE0Im2vWJDRLIvm7V13jVs8gkFuq A==; IronPort-SDR: UHsSSmVe467NpPPvy5vY/9VIlOgEHmwIZGy+/h10+bPyafHrjXWEryVf+D5EAVRIWlDmNV+nVU oyYArR0/Maki13gpd5uTCkzgUOazePkSPzA+me2MES5/D92KfVMqQJCsdL3SpXd/zFIlqZ3grB 0mvM847u5qQWMthndGXSEa8A8CPtcRoCmfi4bQLSwUVFxh8/wUQobG/5WUPUnCKhJIhmZma3vH sroAY2xOToZ+wYWg9UAHQ3yZP0cioyD5VdC/B/4tRdY6sVuS7BwwtHGCzSoeKWezaLvfhMbJLZ TVM= X-IronPort-AV: E=Sophos;i="5.69,308,1571673600"; d="scan'208";a="126860105" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 13 Dec 2019 12:10:46 +0800 IronPort-SDR: xNi0y9EisKfpA2mi+kfhd32uLWHjtAfL5E0P0MYA971+WdBPgnbSYi876R4aa57GWvtZmdyfX1 NNgNWlSb2PcX4npfvk6sJ5gqIztETFABauh5M2m5mTxGcmhw1FHi1LP+l+eUCxRF0LOzroO7Rj 5jGQ3v0CYy8JTDzj+0BZajMoRYWK56E3jSyuTbI8vxsCYhxPCV2wRMDe7uN+UMaObmcZoBUuWL JvvNl7OlLHG90hPn6nlpYrAgBVr17OKThnUHzJhGGNg7+HdILNglh3ukUfcSiErlEFIH7ztBX2 DA1ZopbFlaWkzGVyK1L7i7Dx Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 20:05:17 -0800 IronPort-SDR: r+5NYvY5cw/V/r0PJqKMkexmk3ysWt2anI4Ehrh3A5/Q0sAHusfBIAMXprbsH4iwocL8/gn+Qq CUD+67IBM1lTe4VUjwdk11naKe1RD952YS+bKbk1Rp6K5odac4MrXKt3cCACc+i5W2FM2+Bzaz gKjUa1xvMy1r/HzyAGRDW1/yJJfnMq+NP1wehlc/+2vFgGbhBaTFEUNLzvHg5QZ9HUPA6TUmB1 8TS8b48ZWudu5l8j8AsNp7MFFpVce/9N4qo84CxnUSmZiP4PmxJb73IVVVSd5DlChQQfLhAkCV 7CA= WDCIronportException: Internal Received: from naota.dhcp.fujisawa.hgst.com (HELO naota.fujisawa.hgst.com) ([10.149.53.115]) by uls-op-cesaip02.wdc.com with ESMTP; 12 Dec 2019 20:10:44 -0800 From: Naohiro Aota To: linux-btrfs@vger.kernel.org, David Sterba Cc: Chris Mason , Josef Bacik , Nikolay Borisov , Damien Le Moal , Johannes Thumshirn , Hannes Reinecke , Anand Jain , linux-fsdevel@vger.kernel.org, Naohiro Aota Subject: [PATCH v6 04/28] btrfs: disallow RAID5/6 in HMZONED mode Date: Fri, 13 Dec 2019 13:08:51 +0900 Message-Id: <20191213040915.3502922-5-naohiro.aota@wdc.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191213040915.3502922-1-naohiro.aota@wdc.com> References: <20191213040915.3502922-1-naohiro.aota@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Supporting the RAID5/6 profile in HMZONED mode is not trivial. For example, non-full stripe writes will cause overwriting parity blocks. When we do a non-full stripe write, it writes to the parity block with the data at that moment. Then, another write to the stripes will try to overwrite the parity block with new parity value. However, sequential zones do not allow such parity overwriting. Furthermore, using RAID5/6 on SMR drives, which usually have a huge capacity, incur large overhead of rebuild. Such overhead can lead to higher to higher volume failure rate (e.g. additional drive failure during rebuild) because of the increased rebuild time. Thus, let's disable RAID5/6 profile in HMZONED mode for now. Reviewed-by: Johannes Thumshirn Signed-off-by: Naohiro Aota --- fs/btrfs/hmzoned.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/btrfs/hmzoned.c b/fs/btrfs/hmzoned.c index 0182bfb9c903..1b24facd46b8 100644 --- a/fs/btrfs/hmzoned.c +++ b/fs/btrfs/hmzoned.c @@ -236,6 +236,13 @@ int btrfs_check_hmzoned_mode(struct btrfs_fs_info *fs_info) goto out; } + /* RAID56 is not allowed */ + if (btrfs_fs_incompat(fs_info, RAID56)) { + btrfs_err(fs_info, "HMZONED mode does not support RAID56"); + ret = -EINVAL; + goto out; + } + fs_info->zone_size = zone_size; btrfs_info(fs_info, "HMZONED mode enabled, zone size %llu B", -- 2.24.0