From: Jonathan Corbet <corbet@lwn.net>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Cc: miklos@szeredi.hu, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: filesystems: convert fuse to RST
Date: Thu, 19 Dec 2019 09:53:56 -0700 [thread overview]
Message-ID: <20191219095356.4a3ad965@lwn.net> (raw)
In-Reply-To: <20191120192655.33709-1-dwlsalmeida@gmail.com>
On Wed, 20 Nov 2019 16:26:55 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
>
>
> Converts fuse.txt to reStructuredText format, improving the presentation
> without changing much of the underlying content.
>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> -----------------------------------------------------------
> Changes in v2:
> -Copied FUSE maintainer (Miklos Szeredi)
> -Fixed the reference in the MAINTAINERS file
> -Removed some of the excessive markup in fuse.rst
> -Moved fuse.rst into admin-guide
> -Updated index.rst
So I have to confess that I've lost track of where we stand with this.
Holidays and moving house will do that...apologies. In any case, I have a
couple of additional comments.
[...]
> -There's a control filesystem for FUSE, which can be mounted by:
> +There's a control filesystem for FUSE, which can be mounted by: ::
>
> mount -t fusectl none /sys/fs/fuse/connections
Please just do "...can be mounted by::"; it will do what you want.
> -Mounting it under the '/sys/fs/fuse/connections' directory makes it
> +Mounting it under the ``'/sys/fs/fuse/connections'`` directory makes it
There's still a lot of extra markup, and this seems like *way* too many
quotes...
> -INTERRUPT requests take precedence over other requests, so the
> +*INTERRUPT* requests take precedence over other requests, so the
> userspace filesystem will receive queued INTERRUPTs before any others.
Not sure you need to add that markup either, but beyond that...
> -The userspace filesystem may ignore the INTERRUPT requests entirely,
> -or may honor them by sending a reply to the _original_ request, with
> -the error set to EINTR.
> +The userspace filesystem may ignore the *INTERRUPT* requests entirely,
> +or may honor them by sending a reply to the *original* request, with
> +the error set to ``EINTR``.
>
> It is also possible that there's a race between processing the
> original request and its INTERRUPT request. There are two possibilities:
>
> - 1) The INTERRUPT request is processed before the original request is
> + #. The *INTERRUPT* request is processed before the original request is
> processed
>
> - 2) The INTERRUPT request is processed after the original request has
> + #. The *INTERRUPT* request is processed after the original request has
> been answered
>
> If the filesystem cannot find the original request, it should wait for
> some timeout and/or a number of new requests to arrive, after which it
> -should reply to the INTERRUPT request with an EAGAIN error. In case
> -1) the INTERRUPT request will be requeued. In case 2) the INTERRUPT
> +should reply to the INTERRUPT request with an ``EAGAIN`` error. In case
> +1) the ``INTERRUPT`` request will be requeued. In case 2) the ``INTERRUPT``
> reply will be ignored.
Here you are marking up the same term in a different way. That can only
create confusion, which is generally not the goal for the docs.
Please make another pass and try to get the markup down to a minimum;
remember that the plain-text reading experience matters too.
Thanks,
jon
next prev parent reply other threads:[~2019-12-19 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 19:26 [PATCH v2] Documentation: filesystems: convert fuse to RST Daniel W. S. Almeida
2019-11-25 10:41 ` Miklos Szeredi
2019-11-30 4:58 ` Daniel W. S. Almeida
2019-12-19 16:53 ` Jonathan Corbet [this message]
2019-12-19 17:01 ` Daniel W. S. Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219095356.4a3ad965@lwn.net \
--to=corbet@lwn.net \
--cc=dwlsalmeida@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).