From: Andrew Morton <email@example.com> To: "Theodore Ts'o" <firstname.lastname@example.org> Cc: Linux Filesystem Development List <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH -v2] memcg: fix a crash in wb_workfn when a device disappears Date: Tue, 7 Jan 2020 15:33:48 -0800 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri, 27 Dec 2019 19:52:11 -0500 "Theodore Ts'o" <email@example.com> wrote: > Without memcg, there is a one-to-one mapping between the bdi and > bdi_writeback structures. In this world, things are fairly > straightforward; the first thing bdi_unregister() does is to shutdown > the bdi_writeback structure (or wb), and part of that writeback > ensures that no other work queued against the wb, and that the wb is > fully drained. > > With memcg, however, there is a one-to-many relationship between the > bdi and bdi_writeback structures; that is, there are multiple wb > objects which can all point to a single bdi. There is a refcount > which prevents the bdi object from being released (and hence, > unregistered). So in theory, the bdi_unregister() *should* only get > called once its refcount goes to zero (bdi_put will drop the refcount, > and when it is zero, release_bdi gets called, which calls > bdi_unregister). > > Unfortunately, del_gendisk() in block/gen_hd.c never got the memo > about the Brave New memcg World, and calls bdi_unregister directly. > It does this without informing the file system, or the memcg code, or > anything else. This causes the root wb associated with the bdi to be > unregistered, but none of the memcg-specific wb's are shutdown. So when > one of these wb's are woken up to do delayed work, they try to > dereference their wb->bdi->dev to fetch the device name, but > unfortunately bdi->dev is now NULL, thanks to the bdi_unregister() > called by del_gendisk(). As a result, *boom*. > > Fortunately, it looks like the rest of the writeback path is perfectly > happy with bdi->dev and bdi->owner being NULL, so the simplest fix is > to create a bdi_dev_name() function which can handle bdi->dev being > NULL. This also allows us to bulletproof the writeback tracepoints to > prevent them from dereferencing a NULL pointer and crashing the kernel > if one is tracing with memcg's enabled, and an iSCSI device dies or a > USB storage stick is pulled. > Is hotremoval of a device while tracing writeback the only known way of triggering this? Is it worth a cc:stable?
next prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-27 19:48 [PATCH] " Theodore Ts'o 2019-12-27 20:31 ` Theodore Ts'o 2019-12-27 21:16 ` kbuild test robot 2019-12-27 21:19 ` Theodore Y. Ts'o 2019-12-27 22:32 ` kbuild test robot 2019-12-28 0:52 ` [PATCH -v2] " Theodore Ts'o 2020-01-03 17:15 ` Theodore Y. Ts'o 2020-01-03 17:46 ` Chris Mason 2020-01-07 23:33 ` Andrew Morton [this message] 2020-01-08 2:12 ` Theodore Y. Ts'o
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Fsdevel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \ email@example.com public-inbox-index linux-fsdevel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git