From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7DCC282DD for ; Thu, 9 Jan 2020 17:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7127F2080D for ; Thu, 9 Jan 2020 17:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388278AbgAIRqx (ORCPT ); Thu, 9 Jan 2020 12:46:53 -0500 Received: from mga03.intel.com ([134.134.136.65]:13542 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731838AbgAIRqw (ORCPT ); Thu, 9 Jan 2020 12:46:52 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 09:46:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,414,1571727600"; d="scan'208";a="396165253" Received: from chenyu-office.sh.intel.com ([10.239.158.173]) by orsmga005.jf.intel.com with ESMTP; 09 Jan 2020 09:46:49 -0800 Date: Fri, 10 Jan 2020 01:45:45 +0800 From: Yu Chen To: Chris Down Cc: x86@kernel.org, Thomas Gleixner , Borislav Petkov , Ingo Molnar , "H. Peter Anvin" , Alexey Dobriyan , Andrew Morton , Reinette Chatre , Fenghua Yu , Tony Luck , Michal Hocko , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][RESEND v5] x86/resctrl: Add task resctrl information display Message-ID: <20200109174544.GC11490@chenyu-office.sh.intel.com> References: <20200109135001.10076-1-yu.c.chen@intel.com> <20200109142444.GB61542@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109142444.GB61542@chrisdown.name> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Chris, On Thu, Jan 09, 2020 at 02:24:44PM +0000, Chris Down wrote: > Chen Yu writes: > > +#ifdef CONFIG_PROC_CPU_RESCTRL > > + > > +/* > > + * A task can only be part of one control > > + * group and of one monitoring group which > > + * is associated to that control group. > > + * So one line is simple and clear enough: > > Can we please avoid using the word "control group" to describe these? It's > extremely confusing for readers since it's exactly the same word as used for > actual cgroups, especially since those are also a form of "resource > control"... > > Doesn't official documentation refer to them as "resource groups" to avoid > this? Right, how abut changing change this description to: control group -> resctrl allocation group monitor group -> resctrl monitor group? Yes, the Documentation/x86/resctrl_ui.rst described them as "Resource Control feature", which is composed of allocation and monitor, so distinguish them as above seems to be appropriate. Thanks, Chenyu