From: Qais Yousef <qais.yousef@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
valentin.schneider@arm.com, qperret@google.com,
Patrick Bellasi <patrick.bellasi@matbug.net>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] sched/rt: Add a new sysctl to control uclamp_util_min
Date: Sun, 12 Jan 2020 23:31:22 +0000 [thread overview]
Message-ID: <20200112233122.b26kidww6xphuyqq@e107158-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200110134236.GM2844@hirez.programming.kicks-ass.net>
On 01/10/20 14:42, Peter Zijlstra wrote:
> On Thu, Jan 09, 2020 at 01:00:58PM +0000, Qais Yousef wrote:
> > On 01/08/20 14:44, Peter Zijlstra wrote:
>
> > > Did cpu_uclamp_write() forget to check for input<0 ?
> >
> > Hmm just tried that and it seems so
> >
> > # echo -1 > cpu.uclamp.min
> > # cat cpu.uclamp.min
> > 42949671.96
> >
> > capacity_from_percent(); we check for
> >
> > 7301 if (req.percent > UCLAMP_PERCENT_SCALE) {
> > 7302 req.ret = -ERANGE;
> > 7303 return req;
> > 7304 }
> >
> > But req.percent is s64, maybe it should be u64?
>
> if ((u64)req.percent > UCLAMP_PERCENT_SCALE)
>
> should do, I think.
Okay I'll send a separate fix for that.
Cheers
--
Qais Yousef
next prev parent reply other threads:[~2020-01-12 23:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 16:48 [PATCH] sched/rt: Add a new sysctl to control uclamp_util_min Qais Yousef
2020-01-07 13:42 ` Quentin Perret
2020-01-07 19:30 ` Dietmar Eggemann
2020-01-08 9:51 ` Quentin Perret
2020-01-08 19:16 ` Patrick Bellasi
2020-01-09 11:36 ` Qais Yousef
2020-01-09 11:16 ` Qais Yousef
2020-01-09 11:12 ` Qais Yousef
2020-01-08 13:44 ` Peter Zijlstra
2020-01-08 19:08 ` Patrick Bellasi
2020-01-09 13:00 ` Qais Yousef
2020-01-10 13:39 ` Peter Zijlstra
2020-01-12 23:35 ` Qais Yousef
2020-01-10 13:42 ` Peter Zijlstra
2020-01-12 23:31 ` Qais Yousef [this message]
2020-01-08 18:56 ` Patrick Bellasi
2020-01-09 1:35 ` Valentin Schneider
2020-01-09 9:21 ` Patrick Bellasi
2020-01-09 13:38 ` Qais Yousef
2020-01-14 21:34 ` Qais Yousef
2020-01-22 10:19 ` Patrick Bellasi
2020-01-22 11:45 ` Qais Yousef
2020-01-22 12:44 ` Patrick Bellasi
2020-01-22 14:57 ` Qais Yousef
2020-01-09 13:15 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200112233122.b26kidww6xphuyqq@e107158-lin.cambridge.arm.com \
--to=qais.yousef@arm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).