From: Vivek Goyal <vgoyal@redhat.com>
To: dan.j.williams@intel.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org
Subject: Re: dax: Get rid of fs_dax_get_by_host() helper
Date: Thu, 16 Jan 2020 09:54:03 -0500 [thread overview]
Message-ID: <20200116145403.GB25291@redhat.com> (raw)
In-Reply-To: <20200106181117.GA16248@redhat.com>
On Mon, Jan 06, 2020 at 01:11:17PM -0500, Vivek Goyal wrote:
> Looks like nobody is using fs_dax_get_by_host() except fs_dax_get_by_bdev()
> and it can easily use dax_get_by_host() instead.
>
> IIUC, fs_dax_get_by_host() was only introduced so that one could compile
> with CONFIG_FS_DAX=n and CONFIG_DAX=m. fs_dax_get_by_bdev() achieves
> the same purpose and hence it looks like fs_dax_get_by_host() is not
> needed anymore.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Hi Dan,
Ping for this patch. How does it look to you. If you don't have concerns,
can you please take it in your tree.
Thanks
Vivek
> ---
> drivers/dax/super.c | 2 +-
> include/linux/dax.h | 10 ----------
> 2 files changed, 1 insertion(+), 11 deletions(-)
>
> Index: rhvgoyal-linux-fuse/drivers/dax/super.c
> ===================================================================
> --- rhvgoyal-linux-fuse.orig/drivers/dax/super.c 2020-01-03 11:19:57.616186062 -0500
> +++ rhvgoyal-linux-fuse/drivers/dax/super.c 2020-01-03 11:20:08.941186062 -0500
> @@ -61,7 +61,7 @@ struct dax_device *fs_dax_get_by_bdev(st
> {
> if (!blk_queue_dax(bdev->bd_queue))
> return NULL;
> - return fs_dax_get_by_host(bdev->bd_disk->disk_name);
> + return dax_get_by_host(bdev->bd_disk->disk_name);
> }
> EXPORT_SYMBOL_GPL(fs_dax_get_by_bdev);
> #endif
> Index: rhvgoyal-linux-fuse/include/linux/dax.h
> ===================================================================
> --- rhvgoyal-linux-fuse.orig/include/linux/dax.h 2020-01-03 11:20:05.603186062 -0500
> +++ rhvgoyal-linux-fuse/include/linux/dax.h 2020-01-03 11:20:08.942186062 -0500
> @@ -129,11 +129,6 @@ static inline bool generic_fsdax_support
> sectors);
> }
>
> -static inline struct dax_device *fs_dax_get_by_host(const char *host)
> -{
> - return dax_get_by_host(host);
> -}
> -
> static inline void fs_put_dax(struct dax_device *dax_dev)
> {
> put_dax(dax_dev);
> @@ -160,11 +155,6 @@ static inline bool generic_fsdax_support
> return false;
> }
>
> -static inline struct dax_device *fs_dax_get_by_host(const char *host)
> -{
> - return NULL;
> -}
> -
> static inline void fs_put_dax(struct dax_device *dax_dev)
> {
> }
next prev parent reply other threads:[~2020-01-16 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 18:11 dax: Get rid of fs_dax_get_by_host() helper Vivek Goyal
2020-01-10 12:31 ` Christoph Hellwig
2020-01-16 14:54 ` Vivek Goyal [this message]
2020-01-16 18:09 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116145403.GB25291@redhat.com \
--to=vgoyal@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).