linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
	sj1557.seo@samsung.com, arnd@arndb.de, namjae.jeon@samsung.com
Subject: Re: [PATCH v11 02/14] exfat: add super block operations
Date: Sun, 19 Jan 2020 21:52:33 +0100	[thread overview]
Message-ID: <20200119205233.g2kliii2ywilt6tb@pali> (raw)
In-Reply-To: <20200118150348.9972-3-linkinjeon@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

On Sunday 19 January 2020 00:03:36 Namjae Jeon wrote:
> +	case Opt_time_offset:
> +		/*
> +		 * GMT+-12 zones may have DST corrections so at least
> +		 * 13 hours difference is needed. Make the limit 24
> +		 * just in case someone invents something unusual.
> +		 */
> +		if (result.int_32 < -24 * 60 || result.int_32 > 24 * 60)
> +			return -EINVAL;
> +		opts->time_offset = result.int_32;
> +		break;

"13 hours difference is needed"

This is not truth :-) Every traveller knows that Kiribati has only
standard time and is in GMT+14 time zone.

But limit ±24 is enough, at least for now.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  parent reply	other threads:[~2020-01-19 20:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 15:03 [PATCH v11 00/14] add the latest exfat driver Namjae Jeon
2020-01-18 15:03 ` [PATCH v11 01/14] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2020-01-18 15:03 ` [PATCH v11 02/14] exfat: add super block operations Namjae Jeon
2020-01-19 14:24   ` Arnd Bergmann
2020-01-19 20:52   ` Pali Rohár [this message]
2020-01-18 15:03 ` [PATCH v11 03/14] exfat: add inode operations Namjae Jeon
2020-01-19 22:27   ` Christoph Hellwig
2020-01-18 15:03 ` [PATCH v11 04/14] exfat: add directory operations Namjae Jeon
2020-01-18 15:03 ` [PATCH v11 05/14] exfat: add file operations Namjae Jeon
2020-01-19 14:23   ` Arnd Bergmann
2020-01-18 15:03 ` [PATCH v11 06/14] exfat: add fat entry operations Namjae Jeon
2020-01-18 15:03 ` [PATCH v11 07/14] exfat: add bitmap operations Namjae Jeon
2020-01-18 15:03 ` [PATCH v11 08/14] exfat: add exfat cache Namjae Jeon
2020-01-18 15:03 ` [PATCH v11 09/14] exfat: add misc operations Namjae Jeon
2020-01-19 14:22   ` Arnd Bergmann
2020-01-19 22:28   ` Christoph Hellwig
2020-01-18 15:03 ` [PATCH v11 10/14] exfat: add nls operations Namjae Jeon
2020-01-19 22:29   ` Christoph Hellwig
2020-01-18 15:03 ` [PATCH v11 11/14] exfat: add Kconfig and Makefile Namjae Jeon
2020-01-19 22:34   ` Christoph Hellwig
2020-01-18 15:03 ` [PATCH v11 12/14] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2020-01-19 22:34   ` Christoph Hellwig
2020-01-19 23:54     ` Namjae Jeon
2020-01-18 15:03 ` [PATCH v11 13/14] MAINTAINERS: add exfat filesystem Namjae Jeon
2020-01-19 22:35   ` Christoph Hellwig
2020-01-18 15:03 ` [PATCH v11 14/14] staging: exfat: make staging/exfat and fs/exfat mutually exclusive Namjae Jeon
2020-01-19 22:37   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200119205233.g2kliii2ywilt6tb@pali \
    --to=pali.rohar@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linkinjeon@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=sj1557.seo@samsung.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).