From: Vivek Goyal <vgoyal@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
dan.j.williams@intel.com, dm-devel@redhat.com
Subject: Re: [PATCH 2/5] s390,dax: Add dax zero_page_range operation to dcssblk driver
Date: Wed, 5 Feb 2020 15:04:25 -0500 [thread overview]
Message-ID: <20200205200425.GF14544@redhat.com> (raw)
In-Reply-To: <20200205183205.GB26711@infradead.org>
On Wed, Feb 05, 2020 at 10:32:05AM -0800, Christoph Hellwig wrote:
> > diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
> > index 63502ca537eb..f6709200bcd0 100644
> > --- a/drivers/s390/block/dcssblk.c
> > +++ b/drivers/s390/block/dcssblk.c
> > @@ -62,6 +62,7 @@ static const struct dax_operations dcssblk_dax_ops = {
> > .dax_supported = generic_fsdax_supported,
> > .copy_from_iter = dcssblk_dax_copy_from_iter,
> > .copy_to_iter = dcssblk_dax_copy_to_iter,
> > + .zero_page_range = dcssblk_dax_zero_page_range,
> > };
> >
> > struct dcssblk_dev_info {
> > @@ -941,6 +942,12 @@ dcssblk_dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff,
> > return __dcssblk_direct_access(dev_info, pgoff, nr_pages, kaddr, pfn);
> > }
> >
> > +static int dcssblk_dax_zero_page_range(struct dax_device *dax_dev,pgoff_t pgoff,
> > + unsigned offset, size_t len)
> > +{
> > + return generic_dax_zero_page_range(dax_dev, pgoff, offset, len);
> > +}
>
> Wouldn't this need a forward declaration? Then again given that dcssblk
> is the only caller of generic_dax_zero_page_range we might as well merge
> the two. If you want to keep the generic one it could be wired up to
> dcssblk_dax_ops directly, though.
Given dcssblk is the only user, I am inclined to get rid of genric
version. We can add one later if another user shows up.
Thanks
Vivek
next prev parent reply other threads:[~2020-02-05 20:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 20:00 [RFC PATCH 0/5][V2] dax,pmem: Provide a dax operation to zero range of memory Vivek Goyal
2020-02-03 20:00 ` [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range Vivek Goyal
2020-02-05 18:30 ` Christoph Hellwig
2020-02-05 20:02 ` Vivek Goyal
2020-02-06 0:40 ` Dan Williams
2020-02-06 7:41 ` Christoph Hellwig
2020-02-07 16:57 ` Dan Williams
2020-02-07 17:01 ` Vivek Goyal
2020-02-07 17:06 ` Dan Williams
2020-02-06 14:34 ` Vivek Goyal
2020-02-07 16:58 ` Dan Williams
2020-02-03 20:00 ` [PATCH 2/5] s390,dax: Add dax zero_page_range operation to dcssblk driver Vivek Goyal
2020-02-05 18:32 ` Christoph Hellwig
2020-02-05 20:04 ` Vivek Goyal [this message]
2020-02-03 20:00 ` [PATCH 3/5] dm,dax: Add dax zero_page_range operation Vivek Goyal
2020-02-05 18:33 ` Christoph Hellwig
2020-02-07 16:34 ` Vivek Goyal
2020-02-03 20:00 ` [PATCH 4/5] dax,iomap: Start using dax native zero_page_range() Vivek Goyal
2020-02-05 18:33 ` Christoph Hellwig
2020-02-05 20:10 ` Vivek Goyal
2020-02-07 15:31 ` Vivek Goyal
2020-02-03 20:00 ` [PATCH 5/5] dax,iomap: Add helper dax_iomap_zero() to zero a range Vivek Goyal
2020-02-04 5:17 ` kbuild test robot
2020-02-05 18:36 ` Christoph Hellwig
2020-02-05 20:15 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205200425.GF14544@redhat.com \
--to=vgoyal@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).