From: "J. Bruce Fields" <bfields@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] exportfs: fix handling of rename race in reconnect_one()
Date: Thu, 6 Feb 2020 16:10:29 -0500 [thread overview]
Message-ID: <20200206211029.GA53503@pick.fieldses.org> (raw)
In-Reply-To: <CAOQ4uxiXceNbL6jPW9LSH_ijftwHd8NzUACG6w7raZhSoeR1Ew@mail.gmail.com>
On Thu, Feb 06, 2020 at 10:22:21PM +0200, Amir Goldstein wrote:
> On Mon, Jan 27, 2020 at 11:18 PM J. Bruce Fields <bfields@redhat.com> wrote:
> >
> > On Mon, Jan 27, 2020 at 08:38:00PM +0200, Amir Goldstein wrote:
> > > > > Commit 909e22e05353 ("exportfs: fix 'passing zero to ERR_PTR()'
> > > > > warning") changes this behavior from always returning success,
> > > > > regardless if dentry was reconnected by somoe other task, to always
> > > > > returning a failure.
> > > >
> > > > I wonder whether it might be safest to take the out_reconnected case on
> > > > any error, not just -ENOENT.
> > > >
> > >
> > > I wondered that as well, but preferred to follow the precedent.
> >
> > I can live with that.
>
> Will you take this patch through your tree,
> or do you want me to re-post to Al?
If Al wants to delegate exportfs/ patches to nfsd maintainers that's OK
by me, but in the past I think it's always him that's taken them.
> With your Reviewed-by?
That'd be fine. Thanks!
--b.
next prev parent reply other threads:[~2020-02-06 21:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 22:08 [PATCH] exportfs: fix handling of rename race in reconnect_one() Amir Goldstein
2020-01-27 8:04 ` Christoph Hellwig
2020-01-27 17:30 ` J. Bruce Fields
2020-01-27 18:38 ` Amir Goldstein
2020-01-27 21:17 ` J. Bruce Fields
2020-02-06 20:22 ` Amir Goldstein
2020-02-06 21:10 ` J. Bruce Fields [this message]
2020-02-06 21:45 ` Al Viro
2020-02-07 6:26 ` Amir Goldstein
2020-03-13 14:33 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206211029.GA53503@pick.fieldses.org \
--to=bfields@redhat.com \
--cc=amir73il@gmail.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).