From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FBCC3B186 for ; Tue, 11 Feb 2020 05:57:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BED620708 for ; Tue, 11 Feb 2020 05:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728243AbgBKF5t (ORCPT ); Tue, 11 Feb 2020 00:57:49 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:54887 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726942AbgBKF5t (ORCPT ); Tue, 11 Feb 2020 00:57:49 -0500 Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 20B3F3A2BF5; Tue, 11 Feb 2020 16:57:47 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j1OYL-000674-Vx; Tue, 11 Feb 2020 16:57:45 +1100 Date: Tue, 11 Feb 2020 16:57:45 +1100 From: Dave Chinner To: ira.weiny@intel.com Cc: linux-kernel@vger.kernel.org, Alexander Viro , "Darrick J. Wong" , Dan Williams , Christoph Hellwig , "Theodore Y. Ts'o" , Jan Kara , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 04/12] fs/xfs: Clean up DAX support check Message-ID: <20200211055745.GG10776@dread.disaster.area> References: <20200208193445.27421-1-ira.weiny@intel.com> <20200208193445.27421-5-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200208193445.27421-5-ira.weiny@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=l697ptgUJYAA:10 a=QyXUC8HyAAAA:8 a=7-415B0cAAAA:8 a=Tb5DaYjIPDbvzpWIyIsA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Feb 08, 2020 at 11:34:37AM -0800, ira.weiny@intel.com wrote: > From: Ira Weiny > > Rather than open coding xfs_inode_supports_dax() in > xfs_ioctl_setattr_dax_invalidate() export xfs_inode_supports_dax() and > call it in preparation for swapping dax flags. > > This also means updating xfs_inode_supports_dax() to return true for a > directory. That's not correct. This now means S_DAX gets set on directory inodes because both xfs_inode_supports_dax() and the on-disk inode flag checks return true in xfs_diflags_to_iflags(). Hence when we instantiate a directory inode with a DAX inherit hint set on it we'll set S_DAX on the inode and so IS_DAX() will return true for directory inodes... Cheers, Dave. -- Dave Chinner david@fromorbit.com