From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317F8C352A4 for ; Wed, 12 Feb 2020 17:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C7D72168B for ; Wed, 12 Feb 2020 17:54:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qHhw+JIq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727372AbgBLRyp (ORCPT ); Wed, 12 Feb 2020 12:54:45 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:33400 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727054AbgBLRyp (ORCPT ); Wed, 12 Feb 2020 12:54:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7XNKwAQCe0wWD09kLZnG/QEn+5bffeFhq6ruL0n9m7M=; b=qHhw+JIqRJlFPo9Hs7xaQi3qIj Jg2LHudVqRZys2sFoRHD7Qb/sJmBBUXyE6FarlkHqm6U+h7L4UcbNCd3FJMQ/zI4ajl25XX07JpIt Af13uKlDkd2uiD/27TuEMsRcgFliRvCXUGZvQBML2ahaeNR8AP5o34VVM0BfZeRBxmNZJXT1popJX BtQlWvxj8C5lMaDgDVN7JYbuUfXtA/McOdBV2QdrXUUuG0FC+FOT1eHpHpOWvLWoK+f0s5e59/r9m 8DXpQAKt2Lo6Sncqwuc8HVMkcCy1T7qlYRhmOdVN9LecwtySaL05IeohtS9fhNHcu1+Jbmy133RHI fjtPt/XQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1wDl-0003lq-Ey; Wed, 12 Feb 2020 17:54:45 +0000 Date: Wed, 12 Feb 2020 09:54:45 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/25] fs: Introduce i_blocks_per_page Message-ID: <20200212175445.GB11424@infradead.org> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-11-willy@infradead.org> <20200212074453.GH7068@infradead.org> <20200212150540.GE7778@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212150540.GE7778@bombadil.infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 12, 2020 at 07:05:40AM -0800, Matthew Wilcox wrote: > > > + * Return: The number of filesystem blocks covered by this page. > > > + */ > > > +static inline > > > +unsigned int i_blocks_per_page(struct inode *inode, struct page *page) > > > > static inline unisnged int > > i_blocks_per_page(struct inode *inode, struct page *page) > > That's XFS coding style. Linus has specifically forbidden that: > > https://lore.kernel.org/lkml/1054519757.161606@palladium.transmeta.com/ Not just xfs but lots of places. But if you don't like that follow the real Linus style we use elsewhere: static inline unsigned int i_blocks_per_page(struct inode *inode, struct page *page)