Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v4 0/2] vfs: have syncfs() return error when there are writeback errors
@ 2020-02-13 21:02 Jeff Layton
  2020-02-13 21:02 ` [PATCH v4 1/2] vfs: track per-sb writeback errors and report them to syncfs Jeff Layton
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jeff Layton @ 2020-02-13 21:02 UTC (permalink / raw)
  To: viro
  Cc: linux-fsdevel, linux-kernel, linux-api, andres, willy, dhowells,
	hch, jack, akpm, david

v4:
- switch to dedicated errseq_t cursor in struct file for syncfs
- drop ioctl for fetching the errseq_t without syncing

This is the fourth posting of this patchset. After thinking about it
more, I think multiplexing file->f_wb_err based on O_PATH open is just
too weird. I think it'd be better if syncfs() "just worked" as expected
no matter what sort of fd you use, or how you multiplex it with fsync.

Also (at least on x86_64) there is currently a 4 byte pad at the end of
the struct so this doesn't end up growing the memory utilization anyway.
Does anyone object to doing this?

I've also dropped the ioctl patch. I have a draft patch to expose that
via fsinfo, but that functionality is really separate from returning an
error to syncfs. We can look at that after the syncfs piece is settled.

Jeff Layton (2):
  vfs: track per-sb writeback errors and report them to syncfs
  buffer: record blockdev write errors in super_block that it backs

 drivers/dax/device.c    |  1 +
 fs/buffer.c             |  2 ++
 fs/file_table.c         |  1 +
 fs/open.c               |  3 +--
 fs/sync.c               |  6 ++++--
 include/linux/fs.h      | 16 ++++++++++++++++
 include/linux/pagemap.h |  5 ++++-
 7 files changed, 29 insertions(+), 5 deletions(-)

-- 
2.24.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 21:02 [PATCH v4 0/2] vfs: have syncfs() return error when there are writeback errors Jeff Layton
2020-02-13 21:02 ` [PATCH v4 1/2] vfs: track per-sb writeback errors and report them to syncfs Jeff Layton
2020-02-13 21:02 ` [PATCH v4 2/2] buffer: record blockdev write errors in super_block that it backs Jeff Layton
2020-03-03 13:10 ` [PATCH v4 0/2] vfs: have syncfs() return error when there are writeback errors Jeff Layton

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git