From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7BC1C33FE2 for ; Mon, 17 Feb 2020 13:31:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95A072070B for ; Mon, 17 Feb 2020 13:31:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qkeFFr9l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728997AbgBQNbS (ORCPT ); Mon, 17 Feb 2020 08:31:18 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:42940 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728881AbgBQNbR (ORCPT ); Mon, 17 Feb 2020 08:31:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dJ4Zkxvpvz5W+pY+zDjAJt/JTwqlyPBBYfHm14egUVA=; b=qkeFFr9lh/8KJMax3DFt0itzaf BypRniQZWts27SXNLLmWKtXtQ484kFWJZHD70Yeai5ElvP4naO9RkDdMsQTy8sq6UxmJcSGjfvQ4m 7n1qN+ZZ9dzShGPCps+6Va+jNrf9EWVhMRSn2NNViWvChjbMVTODf6khUs5LL2Jcfc8fgxFTbukNc YZp/PfiDXqNhr3pHAQ5ZNCSHpWJW3fvKAkikoseL5209WN3fhp9gXaIBjXVhMf0GdrdIkt1/7eYzJ 5Rj0DV8XbNc5cEsdJrOEak76hRMMkXlox0rFFTY+0qxVkbERzOh/lxlLIXu/rIlbzXwzaO02+enDV YyVU5kZQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3gUX-00082j-MB; Mon, 17 Feb 2020 13:31:17 +0000 Date: Mon, 17 Feb 2020 05:31:17 -0800 From: Christoph Hellwig To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, dan.j.williams@intel.com, hch@infradead.org, dm-devel@redhat.com, jack@suse.cz Subject: Re: [PATCH 2/6] dax,iomap,ext4,ext2,xfs: Save dax_offset in "struct iomap" Message-ID: <20200217133117.GB20444@infradead.org> References: <20200212170733.8092-1-vgoyal@redhat.com> <20200212170733.8092-3-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212170733.8092-3-vgoyal@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 12, 2020 at 12:07:29PM -0500, Vivek Goyal wrote: > Add a new field "sector_t dax_offset" to "struct iomap". This will be > filled by filesystems and dax code will make use of this to convert > sector into page offset (dax_pgoff()), instead of bdev_dax_pgoff(). This > removes the dependency of having to pass in block device for dax operations. NAK. The iomap is not a structure to bolt random layering violation onto.