From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F8EC34025 for ; Mon, 17 Feb 2020 18:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C80B214D8 for ; Mon, 17 Feb 2020 18:17:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i++UDPbr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729857AbgBQSRT (ORCPT ); Mon, 17 Feb 2020 13:17:19 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:38705 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729856AbgBQSRS (ORCPT ); Mon, 17 Feb 2020 13:17:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581963436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QH8Bjd/3ka+mosq6/VNtwycQuftAuaSabII3fWxpEHs=; b=i++UDPbr2gh8VPCLGzyKfTHtRoafg6qAg24hY2fqU6TKBU5PYYLUSEMJZ5ZPeBRrkYtnRx MM4XO4oAfYufYr83Db5D+q3ZZVVW0h/qbPAWIf0NYPSo+rjAsGBWCj0Y1jZARMgAxxlJl7 /oGMPY8IIXOrRACPIh7yyOdbwsI0mms= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-eBcUv0tCNnmOYo2zvfW9_w-1; Mon, 17 Feb 2020 13:17:12 -0500 X-MC-Unique: eBcUv0tCNnmOYo2zvfW9_w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65339800D6C; Mon, 17 Feb 2020 18:17:11 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F70719C69; Mon, 17 Feb 2020 18:17:08 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 0AAA42257D5; Mon, 17 Feb 2020 13:17:08 -0500 (EST) From: Vivek Goyal To: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, hch@infradead.org, dan.j.williams@intel.com Cc: dm-devel@redhat.com, vishal.l.verma@intel.com, vgoyal@redhat.com Subject: [PATCH v4 3/7] dax, pmem: Add a dax operation zero_page_range Date: Mon, 17 Feb 2020 13:16:49 -0500 Message-Id: <20200217181653.4706-4-vgoyal@redhat.com> In-Reply-To: <20200217181653.4706-1-vgoyal@redhat.com> References: <20200217181653.4706-1-vgoyal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Add a dax operation zero_page_range, to zero a range of memory. This will also clear any poison in the range being zeroed. As of now, zeroing of up to one page is allowed in a single call. There are no callers which are trying to zero more than a page in a single call= . Once we grow the callers which zero more than a page in single call, we can add that support. Primary reason for not doing that yet is that this will add little complexity in dm implementation where a range might be spanning multiple underlying targets and one will have to split the range into multiple sub ranges and call zero_page_range() on individual targets= . Suggested-by: Christoph Hellwig Signed-off-by: Vivek Goyal --- drivers/dax/super.c | 19 +++++++++++++++++++ drivers/nvdimm/pmem.c | 11 +++++++++++ include/linux/dax.h | 3 +++ 3 files changed, 33 insertions(+) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index 26a654dbc69a..31ee0b47b4ed 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -344,6 +344,25 @@ size_t dax_copy_to_iter(struct dax_device *dax_dev, = pgoff_t pgoff, void *addr, } EXPORT_SYMBOL_GPL(dax_copy_to_iter); =20 +int dax_zero_page_range(struct dax_device *dax_dev, u64 offset, size_t l= en) +{ + if (!dax_alive(dax_dev)) + return -ENXIO; + + if (!dax_dev->ops->zero_page_range) + return -EOPNOTSUPP; + /* + * There are no callers that want to zero across a page boundary as of + * now. Once users are there, this check can be removed after the + * device mapper code has been updated to split ranges across targets. + */ + if (offset_in_page(offset) + len > PAGE_SIZE) + return -EIO; + + return dax_dev->ops->zero_page_range(dax_dev, offset, len); +} +EXPORT_SYMBOL_GPL(dax_zero_page_range); + #ifdef CONFIG_ARCH_HAS_PMEM_API void arch_wb_cache_pmem(void *addr, size_t size); void dax_flush(struct dax_device *dax_dev, void *addr, size_t size) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index fae8f67da9de..44f660fa56ca 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -296,6 +296,16 @@ static const struct block_device_operations pmem_fop= s =3D { .revalidate_disk =3D nvdimm_revalidate_disk, }; =20 +static int pmem_dax_zero_page_range(struct dax_device *dax_dev, u64 offs= et, + size_t len) +{ + struct pmem_device *pmem =3D dax_get_private(dax_dev); + blk_status_t rc; + + rc =3D pmem_do_write(pmem, ZERO_PAGE(0), 0, offset, len); + return blk_status_to_errno(rc); +} + static long pmem_dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages, void **kaddr, pfn_t *pfn) { @@ -327,6 +337,7 @@ static const struct dax_operations pmem_dax_ops =3D { .dax_supported =3D generic_fsdax_supported, .copy_from_iter =3D pmem_copy_from_iter, .copy_to_iter =3D pmem_copy_to_iter, + .zero_page_range =3D pmem_dax_zero_page_range, }; =20 static const struct attribute_group *pmem_attribute_groups[] =3D { diff --git a/include/linux/dax.h b/include/linux/dax.h index 9bd8528bd305..a555f0aeb7bd 100644 --- a/include/linux/dax.h +++ b/include/linux/dax.h @@ -34,6 +34,8 @@ struct dax_operations { /* copy_to_iter: required operation for fs-dax direct-i/o */ size_t (*copy_to_iter)(struct dax_device *, pgoff_t, void *, size_t, struct iov_iter *); + /* zero_page_range: required operation. Zero range with-in a page */ + int (*zero_page_range)(struct dax_device *, u64, size_t); }; =20 extern struct attribute_group dax_attribute_group; @@ -209,6 +211,7 @@ size_t dax_copy_from_iter(struct dax_device *dax_dev,= pgoff_t pgoff, void *addr, size_t bytes, struct iov_iter *i); size_t dax_copy_to_iter(struct dax_device *dax_dev, pgoff_t pgoff, void = *addr, size_t bytes, struct iov_iter *i); +int dax_zero_page_range(struct dax_device *dax_dev, u64 offset, size_t l= en); void dax_flush(struct dax_device *dax_dev, void *addr, size_t size); =20 ssize_t dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter, --=20 2.20.1