From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5087C34027 for ; Mon, 17 Feb 2020 18:17:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2EFA207FD for ; Mon, 17 Feb 2020 18:17:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NRAjtCaw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729867AbgBQSRS (ORCPT ); Mon, 17 Feb 2020 13:17:18 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:45580 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728857AbgBQSRR (ORCPT ); Mon, 17 Feb 2020 13:17:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581963435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2GzqxUysJp77BafIkGkM9UKjB5x/duPjdTnwyoWtsCE=; b=NRAjtCawVqGNUNvEcvezN+feaLwjf/9OwmHHaK733evReDRvIjMAxnr45l+1lOZvhrdd4s s9a2o9NjZEIyqvZBIPDjRSnvApvIHyhSlVHzaNSf66Q9/p7KKoYVcdrvyS/7U016vb63Of JxeuJTWAtB3QN/iC+XZKx6Pi8koBBrg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-OdHrqrOlNd6TEsIUM4fQLA-1; Mon, 17 Feb 2020 13:17:13 -0500 X-MC-Unique: OdHrqrOlNd6TEsIUM4fQLA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A51910CE78D; Mon, 17 Feb 2020 18:17:12 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6C9360BE1; Mon, 17 Feb 2020 18:17:11 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 20D4A2257D9; Mon, 17 Feb 2020 13:17:08 -0500 (EST) From: Vivek Goyal To: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, hch@infradead.org, dan.j.williams@intel.com Cc: dm-devel@redhat.com, vishal.l.verma@intel.com, vgoyal@redhat.com, Christoph Hellwig Subject: [PATCH v4 7/7] dax,iomap: Add helper dax_iomap_zero() to zero a range Date: Mon, 17 Feb 2020 13:16:53 -0500 Message-Id: <20200217181653.4706-8-vgoyal@redhat.com> In-Reply-To: <20200217181653.4706-1-vgoyal@redhat.com> References: <20200217181653.4706-1-vgoyal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Add a helper dax_ioamp_zero() to zero a range. This patch basically merges __dax_zero_page_range() and iomap_dax_zero(). Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Vivek Goyal --- fs/dax.c | 12 ++++++------ fs/iomap/buffered-io.c | 9 +-------- include/linux/dax.h | 17 +++-------------- 3 files changed, 10 insertions(+), 28 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index 6757e12b86b2..f6c4788ba764 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1044,23 +1044,23 @@ static vm_fault_t dax_load_hole(struct xa_state *= xas, return ret; } =20 -int __dax_zero_page_range(struct block_device *bdev, - struct dax_device *dax_dev, sector_t sector, - unsigned int offset, unsigned int size) +int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, + struct iomap *iomap) { pgoff_t pgoff; long rc, id; + sector_t sector =3D iomap_sector(iomap, pos & PAGE_MASK); =20 - rc =3D bdev_dax_pgoff(bdev, sector, PAGE_SIZE, &pgoff); + rc =3D bdev_dax_pgoff(iomap->bdev, sector, PAGE_SIZE, &pgoff); if (rc) return rc; =20 id =3D dax_read_lock(); - rc =3D dax_zero_page_range(dax_dev, (pgoff << PAGE_SHIFT) + offset, siz= e); + rc =3D dax_zero_page_range(iomap->dax_dev, (pgoff << PAGE_SHIFT) + offs= et, + size); dax_read_unlock(id); return rc; } -EXPORT_SYMBOL_GPL(__dax_zero_page_range); =20 static loff_t dax_iomap_actor(struct inode *inode, loff_t pos, loff_t length, void *da= ta, diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 7c84c4c027c4..6f750da545e5 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -974,13 +974,6 @@ static int iomap_zero(struct inode *inode, loff_t po= s, unsigned offset, return iomap_write_end(inode, pos, bytes, bytes, page, iomap, srcmap); } =20 -static int iomap_dax_zero(loff_t pos, unsigned offset, unsigned bytes, - struct iomap *iomap) -{ - return __dax_zero_page_range(iomap->bdev, iomap->dax_dev, - iomap_sector(iomap, pos & PAGE_MASK), offset, bytes); -} - static loff_t iomap_zero_range_actor(struct inode *inode, loff_t pos, loff_t count, void *data, struct iomap *iomap, struct iomap *srcmap) @@ -1000,7 +993,7 @@ iomap_zero_range_actor(struct inode *inode, loff_t p= os, loff_t count, bytes =3D min_t(loff_t, PAGE_SIZE - offset, count); =20 if (IS_DAX(inode)) - status =3D iomap_dax_zero(pos, offset, bytes, iomap); + status =3D dax_iomap_zero(pos, offset, bytes, iomap); else status =3D iomap_zero(inode, pos, offset, bytes, iomap, srcmap); diff --git a/include/linux/dax.h b/include/linux/dax.h index a555f0aeb7bd..31d0e6fc3023 100644 --- a/include/linux/dax.h +++ b/include/linux/dax.h @@ -13,6 +13,7 @@ typedef unsigned long dax_entry_t; =20 struct iomap_ops; +struct iomap; struct dax_device; struct dax_operations { /* @@ -223,20 +224,8 @@ vm_fault_t dax_finish_sync_fault(struct vm_fault *vm= f, int dax_delete_mapping_entry(struct address_space *mapping, pgoff_t inde= x); int dax_invalidate_mapping_entry_sync(struct address_space *mapping, pgoff_t index); - -#ifdef CONFIG_FS_DAX -int __dax_zero_page_range(struct block_device *bdev, - struct dax_device *dax_dev, sector_t sector, - unsigned int offset, unsigned int length); -#else -static inline int __dax_zero_page_range(struct block_device *bdev, - struct dax_device *dax_dev, sector_t sector, - unsigned int offset, unsigned int length) -{ - return -ENXIO; -} -#endif - +int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, + struct iomap *iomap); static inline bool dax_mapping(struct address_space *mapping) { return mapping->host && IS_DAX(mapping->host); --=20 2.20.1