From: Stefano Garzarella <sgarzare@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] io_uring: remove unnecessary NULL checks
Date: Tue, 18 Feb 2020 13:31:35 +0100 [thread overview]
Message-ID: <20200218123135.5iihagj3lkwx4h52@steredhat> (raw)
In-Reply-To: <20200217143945.ua4lawkg22ggfihr@kili.mountain>
On Mon, Feb 17, 2020 at 05:39:45PM +0300, Dan Carpenter wrote:
> The "kmsg" pointer can't be NULL and we have already dereferenced it so
> a check here would be useless.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/io_uring.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 72bc378edebc..e9f339453ddb 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -3065,7 +3065,7 @@ static int io_sendmsg(struct io_kiocb *req, struct io_kiocb **nxt,
> if (req->io)
> return -EAGAIN;
> if (io_alloc_async_ctx(req)) {
> - if (kmsg && kmsg->iov != kmsg->fast_iov)
> + if (kmsg->iov != kmsg->fast_iov)
> kfree(kmsg->iov);
> return -ENOMEM;
> }
> @@ -3219,7 +3219,7 @@ static int io_recvmsg(struct io_kiocb *req, struct io_kiocb **nxt,
> if (req->io)
> return -EAGAIN;
> if (io_alloc_async_ctx(req)) {
> - if (kmsg && kmsg->iov != kmsg->fast_iov)
> + if (kmsg->iov != kmsg->fast_iov)
> kfree(kmsg->iov);
> return -ENOMEM;
> }
Make sense.
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
next prev parent reply other threads:[~2020-02-18 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 14:39 [PATCH] io_uring: remove unnecessary NULL checks Dan Carpenter
2020-02-18 12:31 ` Stefano Garzarella [this message]
2020-02-18 18:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218123135.5iihagj3lkwx4h52@steredhat \
--to=sgarzare@redhat.com \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=io-uring@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).