From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AF6C35669 for ; Fri, 21 Feb 2020 23:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C85620722 for ; Fri, 21 Feb 2020 23:04:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729137AbgBUXEX (ORCPT ); Fri, 21 Feb 2020 18:04:23 -0500 Received: from mga01.intel.com ([192.55.52.88]:34606 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726826AbgBUXEX (ORCPT ); Fri, 21 Feb 2020 18:04:23 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2020 15:04:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,470,1574150400"; d="scan'208";a="225361110" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by orsmga007.jf.intel.com with ESMTP; 21 Feb 2020 15:04:22 -0800 Date: Fri, 21 Feb 2020 15:04:22 -0800 From: Ira Weiny To: Dave Chinner Cc: linux-kernel@vger.kernel.org, Jan Kara , Alexander Viro , "Darrick J. Wong" , Dan Williams , Christoph Hellwig , "Theodore Y. Ts'o" , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V4 03/13] fs: Remove unneeded IS_DAX() check Message-ID: <20200221230421.GB6762@iweiny-DESK2.sc.intel.com> References: <20200221004134.30599-1-ira.weiny@intel.com> <20200221004134.30599-4-ira.weiny@intel.com> <20200221014225.GV10776@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221014225.GV10776@dread.disaster.area> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Feb 21, 2020 at 12:42:25PM +1100, Dave Chinner wrote: > On Thu, Feb 20, 2020 at 04:41:24PM -0800, ira.weiny@intel.com wrote: > > From: Ira Weiny > > > > Remove the check because DAX now has it's own read/write methods and > > file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on > > their own. Therefore, it does not matter if the file state is DAX when > > the iocb flags are created. > > > > Reviewed-by: Jan Kara > > Signed-off-by: Ira Weiny > > Yup, looks good. > > Reviewed-by: Dave Chinner Thanks, Ira > -- > Dave Chinner > david@fromorbit.com