From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52F1C38C02 for ; Mon, 24 Feb 2020 21:37:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70D1021556 for ; Mon, 24 Feb 2020 21:37:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="X8jrNEtX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbgBXVhP (ORCPT ); Mon, 24 Feb 2020 16:37:15 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:32794 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727421AbgBXVhP (ORCPT ); Mon, 24 Feb 2020 16:37:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nX5VslAb9aYoRq0onwDHGJTJ67RlRcQ5wURtwjQgsok=; b=X8jrNEtXW298x3gA4/IDu/10Ny 1ViCr7MxaOAVAjf+Zay51p9ufyNNeifHWxRgfL7eg/f6/9IGK8yNGMSs5mcRTo4GJfD5Oha50wx9X RoWUPQWYyRqvieERC9AWCihjU8tiBSlNZrctgEXFVEsQK7++p7wCg2aKVkS1CvjpiIwt9Ve8v+vRf D7/k++eIpijcp7XpCFPS+rlPj4VcVAUYvWzvnFBPmlk7Gt3lfaziHMCRv1B2QDfMJQkNJcugtekWK xrNSMkT+9Wb9QLRQJEabeqGGgvvnwCrUQqnrBXNB6655cSxapzIfAzu7myQkdoaNjUxv8uHXRfmBc zL8XhDxQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6LPe-0005je-RR; Mon, 24 Feb 2020 21:37:14 +0000 Date: Mon, 24 Feb 2020 13:37:14 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 08/24] mm: Remove 'page_offset' from readahead loop Message-ID: <20200224213714.GE13895@infradead.org> References: <20200219210103.32400-1-willy@infradead.org> <20200219210103.32400-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219210103.32400-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 19, 2020 at 01:00:47PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Replace the page_offset variable with 'index + i'. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig