From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E646C4BA21 for ; Wed, 26 Feb 2020 21:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E734324672 for ; Wed, 26 Feb 2020 21:38:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JK7mgAJh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727695AbgBZVi6 (ORCPT ); Wed, 26 Feb 2020 16:38:58 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:50314 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727552AbgBZVi5 (ORCPT ); Wed, 26 Feb 2020 16:38:57 -0500 Received: by mail-pj1-f68.google.com with SMTP id r67so206135pjb.0 for ; Wed, 26 Feb 2020 13:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ICcEQ4gQdYyuJJyaNP/FXqF/GhkUX9RbcqCJbqfCFhk=; b=JK7mgAJhIECWhL4BqCySSQ6RLJa9mVCEkRWbEgclZW6QParWyKb3pKOOzK7P7B2Fds QcJF8TMbhEkv9fkT27o5U2RrqdXSuHQHl3gd7Qlg7QioSGNbW/enlgGOtVHMRwsG9u/z ud39wkvioudcK1LY9iGaZX2XQoE68rMHqRca8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ICcEQ4gQdYyuJJyaNP/FXqF/GhkUX9RbcqCJbqfCFhk=; b=hBb69JsNy5DviIby/Cy6yrepHaIO2Nct3lrUoNzZGHR9ml67v4M2dVURmhtlWRhftB K4hdhyw5Vki2QNiUAlUlALqbiaHWoi5LXlc1K4uz1tOoFTMfGCQTpFplesXFVIcl7cPd 6jZvr6NxBULRmY0dPmyZxnoLGDXohzBqyTLMp4aeyj2y7BUpUqHLfK7DFOPPRGt94YtZ wWm8pcuGIeWOxH7fvLZfcAa2VY2fVwyYiINEtSYq0pQS8XFFVDL8Cv4w29LkZZ7zRzMf xOGefJl2WrPVwKeh0WNaYmkRfng7Mxxj/6XZPbPaliYSh12H5jcg+dVQ4F0KaEwDFHfs JNYg== X-Gm-Message-State: APjAAAX0DnM7a0fTlGa1peyX+UtVxs9tU/zyeKTe2RPT6s2Km4vN+Wgt CwbI0HZMwe8Q5XHL9vZ0o180MQ== X-Google-Smtp-Source: APXvYqy0FqzsDX/eNvJJ9FIhOvUOIrN2vJCL0P6ncKlZEe17n/wI063mdTJEXhlTrLSMfxHAV6Ojog== X-Received: by 2002:a17:902:6ac3:: with SMTP id i3mr1273585plt.111.1582753134753; Wed, 26 Feb 2020 13:38:54 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x197sm188503pfc.47.2020.02.26.13.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 13:38:53 -0800 (PST) Date: Wed, 26 Feb 2020 13:38:53 -0800 From: Kees Cook To: Mark Brown Cc: Catalin Marinas , Will Deacon , Alexander Viro , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H . J . Lu " , Andrew Jones , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudakshina Das , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v7 11/11] arm64: mm: Display guarded pages in ptdump Message-ID: <202002261338.9890367C@keescook> References: <20200226155714.43937-1-broonie@kernel.org> <20200226155714.43937-12-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226155714.43937-12-broonie@kernel.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 26, 2020 at 03:57:14PM +0000, Mark Brown wrote: > v8.5-BTI introduces the GP field in stage 1 translation tables which > indicates that blocks and pages with it set are guarded pages for which > branch target identification checks should be performed. Decode this > when dumping the page tables to aid debugging. > > Signed-off-by: Mark Brown Reviewed-by: Kees Cook -Kees > --- > arch/arm64/mm/dump.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c > index 860c00ec8bd3..78163b7a7dde 100644 > --- a/arch/arm64/mm/dump.c > +++ b/arch/arm64/mm/dump.c > @@ -145,6 +145,11 @@ static const struct prot_bits pte_bits[] = { > .val = PTE_UXN, > .set = "UXN", > .clear = " ", > + }, { > + .mask = PTE_GP, > + .val = PTE_GP, > + .set = "GP", > + .clear = " ", > }, { > .mask = PTE_ATTRINDX_MASK, > .val = PTE_ATTRINDX(MT_DEVICE_nGnRnE), > -- > 2.20.1 > -- Kees Cook