From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org,
adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, hch@infradead.org, cmaiolino@redhat.com
Subject: Re: [PATCHv3 5/6] ext4: Move ext4_fiemap to use iomap framework.
Date: Thu, 27 Feb 2020 11:08:22 +0530 [thread overview]
Message-ID: <20200227053823.3F4B34203F@d06av24.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20200226132720.GQ10728@quack2.suse.cz>
On 2/26/20 6:57 PM, Jan Kara wrote:
> On Wed 26-02-20 15:27:07, Ritesh Harjani wrote:
>> This patch moves ext4_fiemap to use iomap framework.
>> For xattr a new 'ext4_iomap_xattr_ops' is added.
>>
>> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
>
> ...
>
>> -static int ext4_xattr_fiemap(struct inode *inode,
>> - struct fiemap_extent_info *fieinfo)
>> +static int ext4_iomap_xattr_fiemap(struct inode *inode, struct iomap *iomap)
>> {
>> __u64 physical = 0;
>> __u64 length;
>> - __u32 flags = FIEMAP_EXTENT_LAST;
>> int blockbits = inode->i_sb->s_blocksize_bits;
>> int error = 0;
>> + u16 iomap_type;
>>
>> /* in-inode? */
>> if (ext4_test_inode_state(inode, EXT4_STATE_XATTR)) {
>> @@ -5130,40 +4928,44 @@ static int ext4_xattr_fiemap(struct inode *inode,
>> EXT4_I(inode)->i_extra_isize;
>> physical += offset;
>> length = EXT4_SB(inode->i_sb)->s_inode_size - offset;
>> - flags |= FIEMAP_EXTENT_DATA_INLINE;
>> brelse(iloc.bh);
>> + iomap_type = IOMAP_INLINE;
>> } else { /* external block */
>> physical = (__u64)EXT4_I(inode)->i_file_acl << blockbits;
>> length = inode->i_sb->s_blocksize;
>> + iomap_type = IOMAP_MAPPED;
>> }
>
> If i_file_acl is 0 (i.e., no external xattr block), then I think returned
> iomap should be different...
Yes, my bad. Let me fix this please.
>
>> +static int ext4_iomap_xattr_begin(struct inode *inode, loff_t offset,
>> + loff_t length, unsigned flags,
>> + struct iomap *iomap, struct iomap *srcmap)
>> {
>> - ext4_lblk_t start_blk;
>> - u32 ext4_fiemap_flags = FIEMAP_FLAG_SYNC|FIEMAP_FLAG_XATTR;
>> + int error;
>>
>> - int error = 0;
>> -
>> - if (ext4_has_inline_data(inode)) {
>> - int has_inline = 1;
>> + error = ext4_iomap_xattr_fiemap(inode, iomap);
>> + if (error == 0 && (offset >= iomap->length))
>> + error = -ENOENT;
>
> Is ENOENT really correct here? It seems strange to me...
>
Yes, -ENOENT means that there is no mapping beyond this and so iomap
core will stop querying further in iomap_fiemap.
I see that we do the same in case of inline mapping too in
ext4_iomap_begin_report().
-ritesh
next prev parent reply other threads:[~2020-02-27 5:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1582702693.git.riteshh@linux.ibm.com>
2020-02-26 9:57 ` [PATCHv3 1/6] ext4: Add IOMAP_F_MERGED for non-extent based mapping Ritesh Harjani
2020-02-26 12:26 ` Jan Kara
2020-02-26 12:33 ` Ritesh Harjani
2020-02-26 9:57 ` [PATCHv3 2/6] ext4: Optimize ext4_ext_precache for 0 depth Ritesh Harjani
2020-02-26 12:28 ` Jan Kara
2020-02-26 9:57 ` [PATCHv3 3/6] ext4: Move ext4 bmap to use iomap infrastructure Ritesh Harjani
2020-02-26 12:29 ` Jan Kara
2020-02-26 9:57 ` [PATCHv3 4/6] ext4: Make ext4_ind_map_blocks work with fiemap Ritesh Harjani
2020-02-26 12:39 ` Jan Kara
2020-02-26 12:47 ` Ritesh Harjani
2020-02-26 16:11 ` Darrick J. Wong
2020-02-27 5:27 ` Ritesh Harjani
2020-02-26 9:57 ` [PATCHv3 5/6] ext4: Move ext4_fiemap to use iomap framework Ritesh Harjani
2020-02-26 13:27 ` Jan Kara
2020-02-27 5:38 ` Ritesh Harjani [this message]
2020-02-26 9:57 ` [PATCHv3 6/6] Documentation: Correct the description of FIEMAP_EXTENT_LAST Ritesh Harjani
2020-02-26 13:05 ` Matthew Wilcox
2020-02-26 16:17 ` Darrick J. Wong
2020-02-26 17:26 ` Jan Kara
2020-02-27 3:24 ` Dave Chinner
2020-02-27 5:17 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227053823.3F4B34203F@d06av24.portsmouth.uk.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).