From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] iomap: Do not use GFP_NORETRY to allocate BIOs
Date: Mon, 23 Mar 2020 06:20:52 -0700 [thread overview]
Message-ID: <20200323132052.GA7683@infradead.org> (raw)
In-Reply-To: <20200323131244.29435-1-willy@infradead.org>
On Mon, Mar 23, 2020 at 06:12:44AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> If we use GFP_NORETRY, we have to be able to handle failures, and it's
> tricky to handle failure here. Other implementations of ->readpages
> do not attempt to handle BIO allocation failures, so this is no worse.
do_mpage_readpage tries to use it, I guess that is wher I copied it
from..
But I don't think it is a bad idea, so the patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
It probably wants a fixes tag, though:
Fixes: 72b4daa24129 ("iomap: add an iomap-based readpage and readpages implementation")
next prev parent reply other threads:[~2020-03-23 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 13:12 [PATCH] iomap: Do not use GFP_NORETRY to allocate BIOs Matthew Wilcox
2020-03-23 13:20 ` Christoph Hellwig [this message]
2020-03-23 13:40 ` Matthew Wilcox
2020-03-23 13:55 ` Christoph Hellwig
2020-03-23 15:10 ` Matthew Wilcox
2020-03-23 16:51 ` Christoph Hellwig
2020-03-31 9:21 ` Christoph Hellwig
2020-03-23 15:38 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323132052.GA7683@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).