From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821DCC2D0E5 for ; Thu, 26 Mar 2020 17:07:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5268020714 for ; Thu, 26 Mar 2020 17:07:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RqUeCpX4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbgCZRHR (ORCPT ); Thu, 26 Mar 2020 13:07:17 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57188 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgCZRHR (ORCPT ); Thu, 26 Mar 2020 13:07:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=o9hWonZdK7qOdVSuVgvE7D7VzhV6FqrA9zPqPwq++AA=; b=RqUeCpX4KPGswjWK1+3HquX3N1 ZXCmC4fXIqQ5JArb8viyWEIB0miaeAhv/Ko5UZYhvcnN5Cw4l8uEQjXjiwHs5T4jLtFFjzvaN/tEp wbBjor5Ybg/+m/iVZUJREOCN+yVRHlN7LyWHyjbKh31ubPajaZL7ENVE9NScdhve4QpIZ7wAunnYz L3bBoTRpxgSbI7nxzteytDKmEHardsR/ybmsEn0s9N6nKgR9nc7IBB64gperg2YOQ+ecY5thW+CWK eTKy5yBFykn0db9Ifsm6kxJnxfAaKsLfpZ6hAezvR9fH9uKkIarrZ1ahvGaLCT8NPBP3PWnrRSCFc pmCrMqRQ==; Received: from [2001:4bb8:18c:2a9e:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHVyM-00019E-D1; Thu, 26 Mar 2020 17:07:14 +0000 From: Christoph Hellwig To: Mike Marshall , Martin Brandenburg Cc: devel@lists.orangefs.org, Alexander Viro , linux-fsdevel@vger.kernel.org Subject: [PATCH 2/2] orangefs: don't mess with I_DIRTY_TIMES in orangefs_flush Date: Thu, 26 Mar 2020 18:07:05 +0100 Message-Id: <20200326170705.1552562-3-hch@lst.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200326170705.1552562-1-hch@lst.de> References: <20200326170705.1552562-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org orangefs_flush just writes out data on every close(2) call. There is no need to change anything about the dirty state, especially as orangefs doesn't treat I_DIRTY_TIMES special in any way. The code seems to come from partially open coding vfs_fsync. Fixes: 90fc07065a35 ("orangefs: avoid fsync service operation on flush") Signed-off-by: Christoph Hellwig --- fs/orangefs/file.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c index 173e6ea57a47..af375e049aae 100644 --- a/fs/orangefs/file.c +++ b/fs/orangefs/file.c @@ -645,16 +645,8 @@ static int orangefs_flush(struct file *file, fl_owner_t id) * on an explicit fsync call. This duplicates historical OrangeFS * behavior. */ - struct inode *inode = file->f_mapping->host; int r; - if (inode->i_state & I_DIRTY_TIME) { - spin_lock(&inode->i_lock); - inode->i_state &= ~I_DIRTY_TIME; - spin_unlock(&inode->i_lock); - mark_inode_dirty_sync(inode); - } - r = filemap_write_and_wait_range(file->f_mapping, 0, LLONG_MAX); if (r > 0) return 0; -- 2.25.1