From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBF2C2D0E5 for ; Sat, 28 Mar 2020 21:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D93EB20732 for ; Sat, 28 Mar 2020 21:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="alfNoYU8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727831AbgC1Vxx (ORCPT ); Sat, 28 Mar 2020 17:53:53 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:37629 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727484AbgC1Vxw (ORCPT ); Sat, 28 Mar 2020 17:53:52 -0400 Received: by mail-pj1-f67.google.com with SMTP id o12so5488925pjs.2 for ; Sat, 28 Mar 2020 14:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ovk2bmmHiHq0822krEgDFQkSPYt5Bktnb17JLm/lkJA=; b=alfNoYU8g+4LyDehhJH9iGwAtea55N/Xy8WHF5I5hMwcVa8EuZTEWAbZ7eeEAtCAjD 1YoFtSlC3h2vBfbE0MPFBAhCW1HFfaZquUMB005WQh05V1HgCf9MnCioH/P0sUd516+4 DI0bMW4XCbsmAoMIv05h5N0yfwlGhX5+NtqUE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ovk2bmmHiHq0822krEgDFQkSPYt5Bktnb17JLm/lkJA=; b=tuqDp150s1ZS8JMFSXgD6+DRWyNqmXWXEd4+ZK52myZZtKB+1DgV/c9GHAxZtUf/rx 0aoO2rC7RzLj0evyRdQmtYazOIB5uqP307C6SztlNhzSB1ht8C8Y81ftakpGuSoooxb+ 0ZAPqT4UwhEBU/EKa5eGzmnTTiKtE3Sk7411JrXcPMC0uCH6f9HOMcds4p1npXdEnST8 VLxSsNOfQA8Zc6CeM4iAzGxoxBi30/EGdAxY6OVc6hp9pRdxcndPS/3nRqmMKYlPMxVT +yoUv0Mo1omkChv9HZXi+KYM56XKhTyRZLd0oItsNMAt8JTZOzCu18D9RvAHbOOofUfB IcYg== X-Gm-Message-State: ANhLgQ0sq/UwM3FmiXxH2YgjO6nZUot+F/7so16p2c+tZAtrGuoedkp7 i6xe0jsAMdXJYrH8YTvXMBAlKQ== X-Google-Smtp-Source: ADFU+vsfxLWSgTsJUgK14r0bXgUXWbEfwzw64SCYCXUXpSNDoac/nQTFCQ7zeikniIjgJ9mfpfaHkA== X-Received: by 2002:a17:90a:fd90:: with SMTP id cx16mr7121093pjb.41.1585432431548; Sat, 28 Mar 2020 14:53:51 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id hg20sm6550839pjb.3.2020.03.28.14.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2020 14:53:50 -0700 (PDT) Date: Sat, 28 Mar 2020 14:53:49 -0700 From: Kees Cook To: Alexey Gladkov Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , "Eric W . Biederman" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Linus Torvalds , Oleg Nesterov Subject: Re: [PATCH v10 7/9] proc: move hidepid values to uapi as they are user interface to mount Message-ID: <202003281453.CED94974@keescook> References: <20200327172331.418878-1-gladkov.alexey@gmail.com> <20200327172331.418878-8-gladkov.alexey@gmail.com> <202003281340.B73225DCC9@keescook> <20200328212547.xxiqxqhxzwp6w5n5@comp-core-i7-2640m-0182e6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200328212547.xxiqxqhxzwp6w5n5@comp-core-i7-2640m-0182e6> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Mar 28, 2020 at 10:25:47PM +0100, Alexey Gladkov wrote: > On Sat, Mar 28, 2020 at 01:41:02PM -0700, Kees Cook wrote: > > diff --git a/include/uapi/linux/proc_fs.h b/include/uapi/linux/proc_fs.h > > > new file mode 100644 > > > index 000000000000..dc6d717aa6ec > > > --- /dev/null > > > +++ b/include/uapi/linux/proc_fs.h > > > @@ -0,0 +1,13 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > +#ifndef _UAPI_PROC_FS_H > > > +#define _UAPI_PROC_FS_H > > > + > > > +/* definitions for hide_pid field */ > > > +enum { > > > + HIDEPID_OFF = 0, > > > + HIDEPID_NO_ACCESS = 1, > > > + HIDEPID_INVISIBLE = 2, > > > + HIDEPID_NOT_PTRACEABLE = 4, > > > +}; > > > + > > > +#endif > > > -- > > > 2.25.2 > > > > > > > Should the numeric values still be UAPI if there is string parsing now? > > I think yes, because these are still valid hidepid= values. But if we don't expose the values, we can do whatever we like with future numbers (e.g. the "is this a value or a bit field?" question). -- Kees Cook