From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE59C43331 for ; Sat, 28 Mar 2020 22:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BA7820714 for ; Sat, 28 Mar 2020 22:54:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbgC1Wyq (ORCPT ); Sat, 28 Mar 2020 18:54:46 -0400 Received: from raptor.unsafe.ru ([5.9.43.93]:39284 "EHLO raptor.unsafe.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727716AbgC1Wyp (ORCPT ); Sat, 28 Mar 2020 18:54:45 -0400 Received: from comp-core-i7-2640m-0182e6 (ip-89-102-33-211.net.upcbroadband.cz [89.102.33.211]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by raptor.unsafe.ru (Postfix) with ESMTPSA id B3BD8209BD; Sat, 28 Mar 2020 22:54:41 +0000 (UTC) Date: Sat, 28 Mar 2020 23:54:36 +0100 From: Alexey Gladkov To: Kees Cook Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , "Eric W . Biederman" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Linus Torvalds , Oleg Nesterov Subject: Re: [PATCH v10 8/9] proc: use human-readable values for hidehid Message-ID: <20200328225436.m3f72nutyq352i2w@comp-core-i7-2640m-0182e6> References: <20200327172331.418878-1-gladkov.alexey@gmail.com> <20200327172331.418878-9-gladkov.alexey@gmail.com> <202003281321.A69D9DE45@keescook> <20200328211453.w44fvkwleltnc2m7@comp-core-i7-2640m-0182e6> <202003281451.88C7CBD23C@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202003281451.88C7CBD23C@keescook> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.1 (raptor.unsafe.ru [5.9.43.93]); Sat, 28 Mar 2020 22:54:43 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Mar 28, 2020 at 02:52:55PM -0700, Kees Cook wrote: > On Sat, Mar 28, 2020 at 10:14:53PM +0100, Alexey Gladkov wrote: > > On Sat, Mar 28, 2020 at 01:28:28PM -0700, Kees Cook wrote: > > > On Fri, Mar 27, 2020 at 06:23:30PM +0100, Alexey Gladkov wrote: > > > > [...] > > > > + if (!kstrtouint(param->string, base, &result.uint_32)) { > > > > + ctx->hidepid = result.uint_32; > > > > > > This need to bounds-check the value with a call to valid_hidepid(), yes? > > > > The kstrtouint returns 0 on success and -ERANGE on overflow [1]. > > No, I mean, hidepid cannot be just any uint32 value. It must be in the > enum. Is that checked somewhere else? It looked like the call to > valid_hidepid() was removed. The valid_hidepid() is called after parsing the hidepid parameter value. Yes, it can be called inside this condition. -- Rgrds, legion