From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDCB3C2D0EF for ; Tue, 31 Mar 2020 09:21:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC7572166E for ; Tue, 31 Mar 2020 09:21:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dZM+SjPD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731568AbgCaJVM (ORCPT ); Tue, 31 Mar 2020 05:21:12 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:60482 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731305AbgCaJVK (ORCPT ); Tue, 31 Mar 2020 05:21:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yqNlown0MzgWJHh7vQQU8YQxRZVzreHtSlK6DAEVltU=; b=dZM+SjPDyPx2aDRbdMAcvY6BM4 bYgSP7hH5mr+/1aMS6aiCd5ttX76Qx8kdNvJr+dgPxck7c1oSTDQG/JHoHhCGKzwqq0bUacWI9XH+ YVtcF4LUB8jcxOoFoHjwP6s3ubbLWvLSJGjQo7ANjT97ZB4HELHYf9/4FiLxxLiVocluxsLNPYRno AHR9TUi9rLge2FbDKrRVH240Uo5T8EjVY2l2c6v1lrmtDu0bdi+prc6D0AQEi3+d8tmS2C9W4d2Xt rKu1PDCzjmbP3XkeDzRkA1KaX9YwzkXK5FukAoZed4GcVZg/c/xBKmpllatHpsoc2xRCUBgX3VV5H +XPv4lqg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJD54-0006ai-Lk; Tue, 31 Mar 2020 09:21:10 +0000 Date: Tue, 31 Mar 2020 02:21:10 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] iomap: Do not use GFP_NORETRY to allocate BIOs Message-ID: <20200331092110.GA24694@infradead.org> References: <20200323131244.29435-1-willy@infradead.org> <20200323132052.GA7683@infradead.org> <20200323134032.GH4971@bombadil.infradead.org> <20200323135500.GA14335@infradead.org> <20200323151054.GI4971@bombadil.infradead.org> <20200323165154.GB30433@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200323165154.GB30433@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Mar 23, 2020 at 09:51:54AM -0700, Christoph Hellwig wrote: > On Mon, Mar 23, 2020 at 08:10:54AM -0700, Matthew Wilcox wrote: > > > That looks silly to me. This just means we'll keep iterating over > > > small bios for readahead.. Either we just ignore the different gfp > > > mask, or we need to go all the way and handle errors, although that > > > doesn't really look nice. > > > > I'm not sure it's silly, > > Oh well, I'm not going to be in the way of fixing a bug I added. So > feel free to go ahead with this and mention it matches mpage_readpages. Are you going to submit this as a formal patch?