From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC328C43331 for ; Fri, 3 Apr 2020 23:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EA88206F8 for ; Fri, 3 Apr 2020 23:59:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Bbhh3fmX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbgDCX71 (ORCPT ); Fri, 3 Apr 2020 19:59:27 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:39674 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbgDCX70 (ORCPT ); Fri, 3 Apr 2020 19:59:26 -0400 Received: by mail-pj1-f65.google.com with SMTP id z3so3740037pjr.4 for ; Fri, 03 Apr 2020 16:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YCa/Qs0yPmh3XTwnN4PsbMB277OSr9D+GN0maXxjMHA=; b=Bbhh3fmXAiGdRNFedcwh3XwyQ26GhP6Z9oRxi/DD0ElrQbHJt8FP23Due9BPsALnlu cdsBGZMeu1Kd8/vgELs72HvtyNixfzg4EaDAo5O2ENQpAqF+HriRbxrU9MqmUByE9IP0 IyiltCvmyvjnf3QdBrKiVqJ2X8ZPSJrLSlitI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YCa/Qs0yPmh3XTwnN4PsbMB277OSr9D+GN0maXxjMHA=; b=eSiIKaTR6iceHuEeQ/RPlWkrM+FJ/QAlKcbAT/5k+b8FOw7IbTv3ugj3tkWh28twoi cC7jPToQLtkAd74qBwpsfRO8V1b8HeIE+Bg05TUFKGnHa3DVNWa/psx832jlQEVhM37n L81B8CsuxR3eFp55dYYXfnzWe/CpEjm3c5OQJ1oHBBLc+WjK87qZgGuepC0zCmdfjyx/ fnQenPugQbZYQfdCF0flmw4gOcf/6juFrxNxuf6tE4RpygIpX3ERQnrHX6LTyLubSD5f bp1zEmZNBEXgwMpCJaOf8hv+6JBtWceX1C0Ggh/wn/M6RK9kGIdg63QHZR3LvaVXK9vO dtSg== X-Gm-Message-State: AGi0PuYy+TyI/l3n3R2XGUJT2CVuoDw69CVGnDNt1j4fUNvlikqtGCKz /Y6kgt6ePlA9O5bdKyBmPoVGEA== X-Google-Smtp-Source: APiQypKaLpvqre5tI8MwDWqt73Tqg7m9h+IsHfp66R3KYbvS+0hTX2lg8k4AHfoG5/7A9eafgxz9Gw== X-Received: by 2002:a17:90a:21ac:: with SMTP id q41mr12995017pjc.41.1585958365843; Fri, 03 Apr 2020 16:59:25 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m3sm6071311pgt.27.2020.04.03.16.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 16:59:24 -0700 (PDT) Date: Fri, 3 Apr 2020 16:59:23 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Alexey Gladkov , LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Alexey Gladkov , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Linus Torvalds , Oleg Nesterov Subject: Re: [PATCH v10 7/9] proc: move hidepid values to uapi as they are user interface to mount Message-ID: <202004031658.8D0C048E3@keescook> References: <20200327172331.418878-1-gladkov.alexey@gmail.com> <20200327172331.418878-8-gladkov.alexey@gmail.com> <875zehkeob.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875zehkeob.fsf@x220.int.ebiederm.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 02, 2020 at 11:58:28AM -0500, Eric W. Biederman wrote: > > I will just say that I do not understand exporting this to the uapi > headers. Why do we want to export the enumeration names? > > I understand that the values are uapi. This looks like it will make it > difficult to make changes that rename enumeration values to make > the code more readable. > > Given that this patchset goes immediately to using string enumerated > values, I also don't understand the point of exporting > HIDEPID_NOT_PTRACEABLE. I don't think we need to ever let > people use the numeric value. > > My sense is that if we are switching to string values we should > just leave the existing numeric values as backwards compatiblity > and not do anything to make them easier to use. Yeah, that's what I had suggested too. Let's not export this to UAPI. -Kees > > Eric > > > Alexey Gladkov writes: > > > Suggested-by: Alexey Dobriyan > > Reviewed-by: Alexey Dobriyan > > Signed-off-by: Alexey Gladkov > > --- > > include/linux/proc_fs.h | 9 +-------- > > include/uapi/linux/proc_fs.h | 13 +++++++++++++ > > 2 files changed, 14 insertions(+), 8 deletions(-) > > create mode 100644 include/uapi/linux/proc_fs.h > > > > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > > index afd38cae2339..d259817ec913 100644 > > --- a/include/linux/proc_fs.h > > +++ b/include/linux/proc_fs.h > > @@ -7,6 +7,7 @@ > > > > #include > > #include > > +#include > > > > struct proc_dir_entry; > > struct seq_file; > > @@ -27,14 +28,6 @@ struct proc_ops { > > unsigned long (*proc_get_unmapped_area)(struct file *, unsigned long, unsigned long, unsigned long, unsigned long); > > }; > > > > -/* definitions for hide_pid field */ > > -enum { > > - HIDEPID_OFF = 0, > > - HIDEPID_NO_ACCESS = 1, > > - HIDEPID_INVISIBLE = 2, > > - HIDEPID_NOT_PTRACEABLE = 4, /* Limit pids to only ptraceable pids */ > > -}; > > - > > /* definitions for proc mount option pidonly */ > > enum { > > PROC_PIDONLY_OFF = 0, > > diff --git a/include/uapi/linux/proc_fs.h b/include/uapi/linux/proc_fs.h > > new file mode 100644 > > index 000000000000..dc6d717aa6ec > > --- /dev/null > > +++ b/include/uapi/linux/proc_fs.h > > @@ -0,0 +1,13 @@ > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > +#ifndef _UAPI_PROC_FS_H > > +#define _UAPI_PROC_FS_H > > + > > +/* definitions for hide_pid field */ > > +enum { > > + HIDEPID_OFF = 0, > > + HIDEPID_NO_ACCESS = 1, > > + HIDEPID_INVISIBLE = 2, > > + HIDEPID_NOT_PTRACEABLE = 4, > > +}; > > + > > +#endif -- Kees Cook