From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC0FC2BB55 for ; Thu, 16 Apr 2020 14:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE2EA21D7E for ; Thu, 16 Apr 2020 14:31:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VnctTWyT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405616AbgDPObR (ORCPT ); Thu, 16 Apr 2020 10:31:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2394298AbgDPObI (ORCPT ); Thu, 16 Apr 2020 10:31:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBE1EC061A0C for ; Thu, 16 Apr 2020 07:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vhhheZDRF5ha3in5VMD/IA78tE/F9ey45sQgR/A8ceU=; b=VnctTWyTPa1YBWxtIZkFBSsr6T CMAO2ezJRjbSywnkl3wpS5BRSull8mEK8dSy13pBuz8YBohxgrMQDHjAB66aOsDTtQi8LGGnet/Xm p2htxmoYt/au7yBV5T9784/31DwfHdN9eVsPOOBqIa/3Rf7otG/KRpOnfB9g9rqDnJn6/Tr1T3Erz bDpRhdRma2xOLvaYh2lQwoEYD1veoVBa6iVuOYeEpMI/z+zpAfm2EdFisaf8jsFrGNvmZhIupjnE8 qmF6QkUcyHWuIfa/IzDqIjdLe4sNO03IlIx6Cy5YelfK/pKFIaGrW9MDefSsUoYBq47Y5kTGLYb1W 9lfKxf3Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP5Xl-00056H-Cb; Thu, 16 Apr 2020 14:31:05 +0000 Date: Thu, 16 Apr 2020 07:31:05 -0700 From: Matthew Wilcox To: Will Deacon Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Will Deacon Subject: Re: [PATCH 1/2] mm: Remove definition of clear_bit_unlock_is_negative_byte Message-ID: <20200416143105.GG5820@bombadil.infradead.org> References: <20200326122429.20710-1-willy@infradead.org> <20200326122429.20710-2-willy@infradead.org> <20200416124536.GA32565@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416124536.GA32565@willie-the-truck> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 16, 2020 at 01:45:39PM +0100, Will Deacon wrote: > Sorry I missed this, I'm over on @kernel.org now and don't have access to > my old @arm.com address anymore. Oops. Shame they haven't started bouncing it yet, so I didn't know. > > -static inline bool clear_bit_unlock_is_negative_byte(long nr, volatile void *mem) > > -{ > > - clear_bit_unlock(nr, mem); > > - /* smp_mb__after_atomic(); */ > > - return test_bit(PG_waiters, mem); > > -} > > I'd really like to do this, but I worry that the generic definition still > isn't available on all architectures depending on how they pull together > their bitops.h. Have you tried building for alpha or s390? At a quick > glance, they look like they might fall apart :( I haven't, but fortunately the 0day build bot has! It built both s390 and alpha successfully (as well as 120+ other configurations).