From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 627B7C55192 for ; Thu, 23 Apr 2020 11:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4ADD12071C for ; Thu, 23 Apr 2020 11:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbgDWLRD (ORCPT ); Thu, 23 Apr 2020 07:17:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:53494 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726805AbgDWLRD (ORCPT ); Thu, 23 Apr 2020 07:17:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 25783B080; Thu, 23 Apr 2020 11:17:00 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 6DF871E1293; Thu, 23 Apr 2020 13:17:00 +0200 (CEST) Date: Thu, 23 Apr 2020 13:17:00 +0200 From: Jan Kara To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu, adilger@dilger.ca, darrick.wong@oracle.com, hch@infradead.org, Alexander Viro , Dan Carpenter , "Aneesh Kumar K . V" , Murphy Zhou , Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: Re: [PATCH 2/5] ext4: Rename fiemap_check_ranges() to make it ext4 specific Message-ID: <20200423111700.GI3737@quack2.suse.cz> References: <64ab9d5449f6fb96bb8633f1a40cff14ddb5614e.1587555962.git.riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64ab9d5449f6fb96bb8633f1a40cff14ddb5614e.1587555962.git.riteshh@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu 23-04-20 16:17:54, Ritesh Harjani wrote: > This renames the fiemap_check_ranges() copy of function > within ext4/ioctl.c to become ext4_fiemap_check_ranges(). > This is required so that we can finally get rid of this > duplicate version. > Since overlayfs anyways need to use this in it's > ovl_fiemap() function, so later patches make it > available for use by others via EXPORT_SYMBOL. > > Signed-off-by: Ritesh Harjani Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/ioctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c > index bfc1281fc4cb..76a2b5200ba3 100644 > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -734,7 +734,7 @@ static void ext4_fill_fsxattr(struct inode *inode, struct fsxattr *fa) > } > > /* copied from fs/ioctl.c */ > -static int fiemap_check_ranges(struct super_block *sb, > +static int ext4_fiemap_check_ranges(struct super_block *sb, > u64 start, u64 len, u64 *new_len) > { > u64 maxbytes = (u64) sb->s_maxbytes; > @@ -775,7 +775,7 @@ static int ext4_ioctl_get_es_cache(struct file *filp, unsigned long arg) > if (fiemap.fm_extent_count > FIEMAP_MAX_EXTENTS) > return -EINVAL; > > - error = fiemap_check_ranges(sb, fiemap.fm_start, fiemap.fm_length, > + error = ext4_fiemap_check_ranges(sb, fiemap.fm_start, fiemap.fm_length, > &len); > if (error) > return error; > -- > 2.21.0 > -- Jan Kara SUSE Labs, CR