From: Matthew Wilcox <willy@infradead.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Huacai Chen <chenhuacai@gmail.com>,
linux-mips@vger.kernel.org
Subject: Re: [PATCH] fs/seq_file.c: Rename the "Fill" label to avoid build failure
Date: Fri, 24 Apr 2020 04:27:21 -0700 [thread overview]
Message-ID: <20200424112721.GE13910@bombadil.infradead.org> (raw)
In-Reply-To: <1587716944-28250-1-git-send-email-chenhc@lemote.com>
On Fri, Apr 24, 2020 at 04:29:04PM +0800, Huacai Chen wrote:
> MIPS define a "Fill" macro as a cache operation in cacheops.h, this
> will cause build failure under some special configurations. To avoid
> this failure we rename the "Fill" label in seq_file.c.
You should rename the Fill macro in the mips header instead.
I'd suggest Fill_R4000 of R4000_Fill.
next prev parent reply other threads:[~2020-04-24 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 8:29 [PATCH] fs/seq_file.c: Rename the "Fill" label to avoid build failure Huacai Chen
2020-04-24 11:27 ` Matthew Wilcox [this message]
2020-04-25 2:54 ` Huacai Chen
2020-04-26 13:46 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424112721.GE13910@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).