From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=FORGED_MUA_MOZILLA, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1749C55197 for ; Sat, 25 Apr 2020 09:45:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF7D32064C for ; Sat, 25 Apr 2020 09:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726143AbgDYJpA (ORCPT ); Sat, 25 Apr 2020 05:45:00 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39234 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbgDYJpA (ORCPT ); Sat, 25 Apr 2020 05:45:00 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03P9W6lQ122788; Sat, 25 Apr 2020 05:44:42 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30me41wet8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 25 Apr 2020 05:44:42 -0400 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 03P9ifbV145693; Sat, 25 Apr 2020 05:44:41 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 30me41wesr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 25 Apr 2020 05:44:41 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 03P9eC8m027554; Sat, 25 Apr 2020 09:44:39 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma01fra.de.ibm.com with ESMTP id 30mcu88b21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 25 Apr 2020 09:44:39 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03P9ibWq53870994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Apr 2020 09:44:37 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 17E9A4C04A; Sat, 25 Apr 2020 09:44:37 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8E2564C044; Sat, 25 Apr 2020 09:44:33 +0000 (GMT) Received: from localhost.localdomain (unknown [9.79.185.245]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sat, 25 Apr 2020 09:44:33 +0000 (GMT) Subject: Re: [PATCH 0/5] ext4/overlayfs: fiemap related fixes To: Amir Goldstein Cc: Christoph Hellwig , Ext4 , Jan Kara , Theodore Tso , Andreas Dilger , "Darrick J. Wong" , Alexander Viro , Dan Carpenter , "Aneesh Kumar K . V" , Murphy Zhou , Miklos Szeredi , linux-fsdevel , overlayfs References: <20200424101153.GC456@infradead.org> <20200424232024.A39974C046@d06av22.portsmouth.uk.ibm.com> From: Ritesh Harjani Date: Sat, 25 Apr 2020 15:14:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <20200425094433.8E2564C044@d06av22.portsmouth.uk.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-25_05:2020-04-24,2020-04-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004250077 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 4/25/20 2:41 PM, Amir Goldstein wrote: > On Sat, Apr 25, 2020 at 2:20 AM Ritesh Harjani wrote: >> >> Hello Christoph, >> >> Thanks for your review comments. >> >> On 4/24/20 3:41 PM, Christoph Hellwig wrote: >>> I think the right fix is to move fiemap_check_ranges into all the ->fiemap >> >> I do welcome your suggestion here. But I am not sure of what you are >> suggesting should be done as a 1st round of changes for the immediate >> reported problem. >> So currently these patches take the same approach on overlayfs on how >> VFS does it. So as a fix to the overlayfs over ext4 reported problems in >> thread [1] & [2]. I think these patches are doing the right thing. >> >> Also maybe I am biased in some way because as I see these are the right >> fixes with minimal changes only at places which does have a direct >> problem. >> > > FWIW, I agree with you. > And seems like Jan does as well, since he ACKed all your patches. > Current patches would be easier to backport to stable kernels. > > Plus, if we are going to cleanup the fiemap interface, need to look into > FIEMAP_FLAG_SYNC handling. > Does it makes sense to handle this flag in vfs ioctl code and other flags > by filesystem code? > See, iomap_fiemap() takes care of FIEMAP_FLAG_SYNC in addition > to ioctl_fiemap(), so I would think that FIEMAP_FLAG_SYNC should > probably be removed from ioctl_fiemap() and handled by > generic_block_fiemap() and other filesystem specific implementation. Yes, and that too. I too wanted to re-look on the above mentioned part. Thanks for penning it down. -ritesh