From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-ext4@vger.kernel.org, viro@zeniv.linux.org.uk,
jack@suse.cz, tytso@mit.edu, adilger@dilger.ca,
riteshh@linux.ibm.com, amir73il@gmail.com,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 05/11] fs: mark __generic_block_fiemap static
Date: Tue, 28 Apr 2020 08:06:55 -0700 [thread overview]
Message-ID: <20200428150655.GG6741@magnolia> (raw)
In-Reply-To: <20200427181957.1606257-6-hch@lst.de>
On Mon, Apr 27, 2020 at 08:19:51PM +0200, Christoph Hellwig wrote:
> There is no caller left outside of ioctl.c.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/ioctl.c | 4 +---
> include/linux/fs.h | 4 ----
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/fs/ioctl.c b/fs/ioctl.c
> index 282d45be6f453..f55f53c7824bb 100644
> --- a/fs/ioctl.c
> +++ b/fs/ioctl.c
> @@ -299,8 +299,7 @@ static inline loff_t blk_to_logical(struct inode *inode, sector_t blk)
> * If you use this function directly, you need to do your own locking. Use
> * generic_block_fiemap if you want the locking done for you.
> */
> -
> -int __generic_block_fiemap(struct inode *inode,
> +static int __generic_block_fiemap(struct inode *inode,
> struct fiemap_extent_info *fieinfo, loff_t start,
> loff_t len, get_block_t *get_block)
> {
> @@ -445,7 +444,6 @@ int __generic_block_fiemap(struct inode *inode,
>
> return ret;
> }
> -EXPORT_SYMBOL(__generic_block_fiemap);
>
> /**
> * generic_block_fiemap - FIEMAP for block based inodes
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 4f6f59b4f22a8..3104c6f7527b5 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3299,10 +3299,6 @@ static inline int vfs_fstat(int fd, struct kstat *stat)
> extern const char *vfs_get_link(struct dentry *, struct delayed_call *);
> extern int vfs_readlink(struct dentry *, char __user *, int);
>
> -extern int __generic_block_fiemap(struct inode *inode,
> - struct fiemap_extent_info *fieinfo,
> - loff_t start, loff_t len,
> - get_block_t *get_block);
> extern int generic_block_fiemap(struct inode *inode,
> struct fiemap_extent_info *fieinfo, u64 start,
> u64 len, get_block_t *get_block);
> --
> 2.26.1
>
next prev parent reply other threads:[~2020-04-28 15:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 18:19 fix fiemap for ext4 bitmap files (+ cleanups) v2 Christoph Hellwig
2020-04-27 18:19 ` [PATCH 01/11] ext4: fix EXT4_MAX_LOGICAL_BLOCK macro Christoph Hellwig
2020-04-27 18:19 ` [PATCH 02/11] ext4: fix fiemap size checks for bitmap files Christoph Hellwig
2020-05-01 23:20 ` Ritesh Harjani
2020-04-27 18:19 ` [PATCH 03/11] ext4: split _ext4_fiemap Christoph Hellwig
2020-05-01 23:21 ` Ritesh Harjani
2020-04-27 18:19 ` [PATCH 04/11] ext4: remove the call to fiemap_check_flags in ext4_fiemap Christoph Hellwig
2020-05-01 23:21 ` Ritesh Harjani
2020-04-27 18:19 ` [PATCH 05/11] fs: mark __generic_block_fiemap static Christoph Hellwig
2020-04-28 15:06 ` Darrick J. Wong [this message]
2020-05-01 23:22 ` Ritesh Harjani
2020-04-27 18:19 ` [PATCH 06/11] fs: move the fiemap definitions out of fs.h Christoph Hellwig
2020-04-28 15:07 ` Darrick J. Wong
2020-05-01 23:23 ` Ritesh Harjani
2020-04-27 18:19 ` [PATCH 07/11] iomap: fix the iomap_fiemap prototype Christoph Hellwig
2020-04-28 15:08 ` Darrick J. Wong
2020-05-01 23:34 ` Ritesh Harjani
2020-05-05 10:29 ` Christoph Hellwig
2020-04-27 18:19 ` [PATCH 08/11] fs: move fiemap range validation into the file systems instances Christoph Hellwig
2020-04-28 2:35 ` Amir Goldstein
2020-04-28 15:14 ` Darrick J. Wong
2020-05-01 22:49 ` Ritesh Harjani
2020-05-05 10:37 ` Christoph Hellwig
2020-04-27 18:19 ` [PATCH 09/11] fs: handle FIEMAP_FLAG_SYNC in fiemap_prep Christoph Hellwig
2020-04-28 2:26 ` Amir Goldstein
2020-04-28 15:16 ` Darrick J. Wong
2020-05-01 22:52 ` Ritesh Harjani
2020-05-05 10:43 ` Christoph Hellwig
2020-04-27 18:19 ` [PATCH 10/11] fs: remove the access_ok() check in ioctl_fiemap Christoph Hellwig
2020-04-28 15:21 ` Darrick J. Wong
2020-05-05 10:44 ` Christoph Hellwig
2020-05-01 22:56 ` Ritesh Harjani
2020-04-27 18:19 ` [PATCH 11/11] ext4: remove the access_ok() check in ext4_ioctl_get_es_cache Christoph Hellwig
2020-05-01 22:56 ` Ritesh Harjani
2020-05-05 15:43 fix fiemap for ext4 bitmap files (+ cleanups) v3 Christoph Hellwig
2020-05-05 15:43 ` [PATCH 05/11] fs: mark __generic_block_fiemap static Christoph Hellwig
2020-05-06 9:27 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428150655.GG6741@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).