From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, miklos@szeredi.hu,
Chirantan Ekbote <chirantan@chromium.org>,
virtio-fs-list <virtio-fs@redhat.com>
Subject: Re: [PATCH][v2] fuse, virtiofs: Do not alloc/install fuse device in fuse_fill_super_common()
Date: Fri, 1 May 2020 16:22:58 +0100 [thread overview]
Message-ID: <20200501152258.GB221440@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200430171814.GA275398@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
On Thu, Apr 30, 2020 at 01:18:14PM -0400, Vivek Goyal wrote:
> As of now fuse_fill_super_common() allocates and installs one fuse device.
> Filesystems like virtiofs can have more than one filesystem queues and
> can have one fuse device per queue. Give, fuse_fill_super_common() only
> handles one device, virtiofs allocates and installes fuse devices for
> all queues except one.
>
> This makes logic little twisted and hard to understand. It probably
> is better to not do any device allocation/installation in
> fuse_fill_super_common() and let caller take care of it instead.
>
> v2: Removed fuse_dev_alloc_install() call from fuse_fill_super_common().
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> fs/fuse/fuse_i.h | 3 ---
> fs/fuse/inode.c | 30 ++++++++++++++----------------
> fs/fuse/virtio_fs.c | 9 +--------
> 3 files changed, 15 insertions(+), 27 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-01 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 17:18 [PATCH][v2] fuse, virtiofs: Do not alloc/install fuse device in fuse_fill_super_common() Vivek Goyal
2020-05-01 15:22 ` Stefan Hajnoczi [this message]
2020-05-04 13:30 ` Miklos Szeredi
2020-05-04 18:33 ` Vivek Goyal
2020-05-18 12:15 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501152258.GB221440@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=chirantan@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).