From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DF6C28CBC for ; Wed, 6 May 2020 09:32:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4B562073A for ; Wed, 6 May 2020 09:32:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729086AbgEFJcl (ORCPT ); Wed, 6 May 2020 05:32:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:38508 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728640AbgEFJcl (ORCPT ); Wed, 6 May 2020 05:32:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6480DB019; Wed, 6 May 2020 09:32:42 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D796E1E12B1; Wed, 6 May 2020 11:32:38 +0200 (CEST) Date: Wed, 6 May 2020 11:32:38 +0200 From: Jan Kara To: Christoph Hellwig Cc: linux-ext4@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, tytso@mit.edu, adilger@dilger.ca, riteshh@linux.ibm.com, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: Re: [PATCH 11/11] ext4: remove the access_ok() check in ext4_ioctl_get_es_cache Message-ID: <20200506093238.GH17863@quack2.suse.cz> References: <20200505154324.3226743-1-hch@lst.de> <20200505154324.3226743-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505154324.3226743-12-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue 05-05-20 17:43:24, Christoph Hellwig wrote: > access_ok just checks we are fed a proper user pointer. We also do that > in copy_to_user itself, so no need to do this early. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Ritesh Harjani Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/ioctl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c > index f81acbbb1b12e..2162db0c747d2 100644 > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -754,11 +754,6 @@ static int ext4_ioctl_get_es_cache(struct file *filp, unsigned long arg) > fieinfo.fi_extents_max = fiemap.fm_extent_count; > fieinfo.fi_extents_start = ufiemap->fm_extents; > > - if (fiemap.fm_extent_count != 0 && > - !access_ok(fieinfo.fi_extents_start, > - fieinfo.fi_extents_max * sizeof(struct fiemap_extent))) > - return -EFAULT; > - > error = ext4_get_es_cache(inode, &fieinfo, fiemap.fm_start, > fiemap.fm_length); > fiemap.fm_flags = fieinfo.fi_flags; > -- > 2.26.2 > -- Jan Kara SUSE Labs, CR