From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF0DC433DF for ; Wed, 13 May 2020 17:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A3F220671 for ; Wed, 13 May 2020 17:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589391030; bh=DUxmL2DW8AGAbEDV0E3S6D4sSXQdPvCUpnXQhcWR/Ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=d5CHs9OgpmNgoSvvYwPVfbPvNqSNoOhCBgMkBrqH6275DT+r5UJzcNoVPD4O5hulJ G/1x2dh58CEIj+3R3eWB0dex2zm5QwYh028zK4aHdv1Bo0rLQI8tHCBF94fLE7W5ft CBtKrm26nQqvUI9JiDvgqWT+IovRexl7vDq/0wkU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389885AbgEMRa3 (ORCPT ); Wed, 13 May 2020 13:30:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:55432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732731AbgEMRa2 (ORCPT ); Wed, 13 May 2020 13:30:28 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98B3E2053B; Wed, 13 May 2020 17:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589391028; bh=DUxmL2DW8AGAbEDV0E3S6D4sSXQdPvCUpnXQhcWR/Ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uwum2c3QVIrZZTK8102bH9IE8j/ppIJPr2jA9iSaVCnTI6vRkvuPK9CWKzh9OSW+Q Ja2aYpKfBVoClFrP15T4+vEHspb8GhNnlHfFc/vYHCvXEiydgTWIMXyI/Y6q/kX4zP 6Z93+gkKt1WwCVYlW1zTdXo49pvlmgsdvZKt7itM= Date: Wed, 13 May 2020 10:30:26 -0700 From: Eric Biggers To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, Barani Muthukumaran , Kuohong Wang , Kim Boojin Subject: Re: [PATCH v12 04/12] block: Make blk-integrity preclude hardware inline encryption Message-ID: <20200513173026.GD1243@sol.localdomain> References: <20200430115959.238073-1-satyat@google.com> <20200430115959.238073-5-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430115959.238073-5-satyat@google.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 30, 2020 at 11:59:51AM +0000, Satya Tangirala wrote: > Whenever a device supports blk-integrity, make the kernel pretend that > the device doesn't support inline encryption (essentially by setting the > keyslot manager in the request queue to NULL). > > There's no hardware currently that supports both integrity and inline > encryption. However, it seems possible that there will be such hardware > in the near future (like the NVMe key per I/O support that might support > both inline encryption and PI). > > But properly integrating both features is not trivial, and without > real hardware that implements both, it is difficult to tell if it will > be done correctly by the majority of hardware that support both. > So it seems best not to support both features together right now, and > to decide what to do at probe time. > > Signed-off-by: Satya Tangirala Looks good, you can add: Reviewed-by: Eric Biggers - Eric