From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED904C433DF for ; Wed, 13 May 2020 18:19:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9228D2065C for ; Wed, 13 May 2020 18:19:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589393954; bh=SfJxDaSxm0hnHBUQQlW7klJYEBeSvPqH0A5X4yUESvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OssF0oSUKI+h3elhfCinMec9MEjvOis2RXmnh7Z3z3KsvCzXNY69SnsDWhBHYLHMV ligWCWk3T09FQA7mswB9zoKkJLHkrPYpftypmYEychRA0MNyEDEajp9WEUhb/R8TMH Upwa6uxgKvvK7ODgaBuebtZxX7LY6oSqAqQ4DSzU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390013AbgEMSTM (ORCPT ); Wed, 13 May 2020 14:19:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:35966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732845AbgEMSTM (ORCPT ); Wed, 13 May 2020 14:19:12 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4805120659; Wed, 13 May 2020 18:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589393952; bh=SfJxDaSxm0hnHBUQQlW7klJYEBeSvPqH0A5X4yUESvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kt83iOznWMDCO7CN/KhYA7OhhIp+dJ8qjppZYlYd2ZsvQlDtaSkePzBNQ0yXT9cgV 07AV6jluBY8Dd8bzEHcoaYXYWMU8a1QHqZ3QPQR/S4o5OUCUD8o717ISAFRdVYw9yE DQeGKgRVoKhyPjUqErvy36jlZzCZ/Mg+LtCftVEc= Date: Wed, 13 May 2020 11:19:10 -0700 From: Eric Biggers To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, Barani Muthukumaran , Kuohong Wang , Kim Boojin Subject: Re: [PATCH v12 08/12] scsi: ufs: Add inline encryption support to UFS Message-ID: <20200513181910.GH1243@sol.localdomain> References: <20200430115959.238073-1-satyat@google.com> <20200430115959.238073-9-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430115959.238073-9-satyat@google.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 30, 2020 at 11:59:55AM +0000, Satya Tangirala wrote: > @@ -8541,6 +8568,13 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) > /* Reset the attached device */ > ufshcd_vops_device_reset(hba); > > + /* Init crypto */ > + err = ufshcd_hba_init_crypto(hba); > + if (err) { > + dev_err(hba->dev, "crypto setup failed\n"); > + goto out_remove_scsi_host; > + } > + Due to changes in v5.6, this is jumping to the wrong error label. It should be 'free_tmf_queue'. - Eric