From: Al Viro <viro@zeniv.linux.org.uk>
To: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
Cc: axboe@kernel.dk, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] io_uring: call statx directly
Date: Fri, 22 May 2020 01:52:34 +0100 [thread overview]
Message-ID: <20200522005234.GL23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200522005053.GK23230@ZenIV.linux.org.uk>
On Fri, May 22, 2020 at 01:50:53AM +0100, Al Viro wrote:
> On Thu, May 21, 2020 at 05:19:37PM -0700, Bijan Mottahedeh wrote:
> > Calling statx directly both simplifies the interface and avoids potential
> > incompatibilities between sync and async invokations.
> >
> > Signed-off-by: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
> > ---
> > fs/io_uring.c | 53 +++++++----------------------------------------------
> > 1 file changed, 7 insertions(+), 46 deletions(-)
> >
> > diff --git a/fs/io_uring.c b/fs/io_uring.c
> > index 12284ea..0540961 100644
> > --- a/fs/io_uring.c
> > +++ b/fs/io_uring.c
> > @@ -427,7 +427,10 @@ struct io_open {
> > union {
> > unsigned mask;
> > };
> > - struct filename *filename;
> > + union {
> > + struct filename *filename;
> > + const char __user *fname;
> > + };
>
> NAK. io_uring is already has ridiculous amount of multiplexing,
> but this kind of shit is right out.
>
> And frankly, the more I look at it, the more I want to rip
> struct io_open out. This kind of trashcan structures has
> caused tons of headache pretty much every time we had those.
> Don't do it.
s/io_open/io_kiocb/, sorry for typo.
next prev parent reply other threads:[~2020-05-22 0:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 0:19 [PATCH 0/2] io_uring: call statx directly Bijan Mottahedeh
2020-05-22 0:19 ` [PATCH 1/2] statx: allow the system call to be invoked from the kernel Bijan Mottahedeh
2020-05-22 0:19 ` [PATCH 2/2] io_uring: call statx directly Bijan Mottahedeh
2020-05-22 0:50 ` Al Viro
2020-05-22 0:52 ` Al Viro [this message]
2020-05-22 1:21 ` Al Viro
2020-05-22 1:20 ` Bijan Mottahedeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522005234.GL23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=bijan.mottahedeh@oracle.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).