From: Jan Kara <jack@suse.cz>
To: ira.weiny@intel.com
Cc: linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
Eric Biggers <ebiggers@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>, Jeff Moyer <jmoyer@redhat.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/8] fs/ext4: Narrow scope of DAX check in setflags
Date: Fri, 22 May 2020 09:58:19 +0200 [thread overview]
Message-ID: <20200522075819.GA14199@quack2.suse.cz> (raw)
In-Reply-To: <20200521191313.261929-2-ira.weiny@intel.com>
On Thu 21-05-20 12:13:06, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> When preventing DAX and journaling on an inode. Use the effective DAX
> check rather than the mount option.
>
> This will be required to support per inode DAX flags.
>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
...
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index bfc1281fc4cb..5813e5e73eab 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -393,9 +393,9 @@ static int ext4_ioctl_setflags(struct inode *inode,
> if ((jflag ^ oldflags) & (EXT4_JOURNAL_DATA_FL)) {
> /*
> * Changes to the journaling mode can cause unsafe changes to
> - * S_DAX if we are using the DAX mount option.
> + * S_DAX if the inode is DAX
> */
> - if (test_opt(inode->i_sb, DAX)) {
> + if (IS_DAX(inode)) {
> err = -EBUSY;
> goto flags_out;
> }
Now one problem popped up in my mind: We should also make EXT4_JOURNAL_DATA_FL
and EXT4_DAX_FL exclusive so that both cannot be turned on at the same
time. And IS_DAX() check isn't enough for that. Sorry for not noticing
earlier... it's like peeling an onion...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-05-22 7:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 19:13 [PATCH V4 0/8] Enable ext4 support for per-file/directory DAX operations ira.weiny
2020-05-21 19:13 ` [PATCH V4 1/8] fs/ext4: Narrow scope of DAX check in setflags ira.weiny
2020-05-22 7:58 ` Jan Kara [this message]
2020-05-21 19:13 ` [PATCH V4 2/8] fs/ext4: Disallow verity if inode is DAX ira.weiny
2020-05-21 19:13 ` [PATCH V4 3/8] fs/ext4: Change EXT4_MOUNT_DAX to EXT4_MOUNT_DAX_ALWAYS ira.weiny
2020-05-21 19:13 ` [PATCH V4 4/8] fs/ext4: Update ext4_should_use_dax() ira.weiny
2020-05-22 10:41 ` Jan Kara
2020-05-21 19:13 ` [PATCH V4 5/8] fs/ext4: Only change S_DAX on inode load ira.weiny
2020-05-21 19:13 ` [PATCH V4 6/8] fs/ext4: Make DAX mount option a tri-state ira.weiny
2020-05-27 5:54 ` Xiao Yang
2020-05-27 23:50 ` Ira Weiny
2020-05-28 8:56 ` Xiao Yang
2020-05-28 9:41 ` Jan Kara
2020-06-02 1:16 ` Xiao Yang
2020-05-21 19:13 ` [PATCH V4 7/8] fs/ext4: Introduce DAX inode flag ira.weiny
2020-05-22 11:48 ` Jan Kara
2020-05-25 4:39 ` Ira Weiny
2020-05-25 7:28 ` Jan Kara
2020-05-23 5:13 ` Andreas Dilger
2020-05-21 19:13 ` [PATCH V4 8/8] Documentation/dax: Update DAX enablement for ext4 ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522075819.GA14199@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).