From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED43AC433DF for ; Fri, 22 May 2020 17:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0BF42078D for ; Fri, 22 May 2020 17:01:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Z28LLEQQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730449AbgEVRB0 (ORCPT ); Fri, 22 May 2020 13:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730306AbgEVRBZ (ORCPT ); Fri, 22 May 2020 13:01:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA8F5C061A0E for ; Fri, 22 May 2020 10:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=gLqD2Ym91EKXJBAHqVV2mYLV/Hm8QNgpM1LtVmbW9EE=; b=Z28LLEQQtpgCZPJ3IwfLU3iYy9 Zhwmnelwl+XQVnbLmy19xC8vU8d741vxZkeV+1GcEEX9E8IxNmC5dd492xd290BHli1IH0lBb+eqg vA0W0yY0NioC7DG1OWZVLHoDVvspzREqk1x9rYn8x5WAZlmSPMBV1KLb1KMKyq8SiQIFWhBYeOsNC IyRGufBaeRJaJaMFAqPPCC/Wl38scppnqmzOOXdK8L1MBll5odpeqVluPNcjWA/rz6rfb1Io6WMus O+CEijwbJXZqJdYEA1w4+l1sR2EWLzorWh1acTzqmeVOXXqVd+FI9pM+ZdPOdYEtm7TqlfAikPJxk FL8AKr5g==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcB2t-0003lX-S9; Fri, 22 May 2020 17:01:19 +0000 Date: Fri, 22 May 2020 10:01:19 -0700 From: Matthew Wilcox To: Al Viro Cc: Krzysztof Wilczynski , Jeff Layton , "J. Bruce Fields" , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs: Remove duplicated flag from VALID_OPEN_FLAGS Message-ID: <20200522170119.GA31139@bombadil.infradead.org> References: <20200522133723.1091937-1-kw@linux.com> <20200522154719.GS23230@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200522154719.GS23230@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, May 22, 2020 at 04:47:19PM +0100, Al Viro wrote: > On Fri, May 22, 2020 at 01:37:23PM +0000, Krzysztof Wilczynski wrote: > > From: Krzysztof Wilczyński > > > > Also, remove extra tab after the FASYNC flag, and keep line under 80 > > characters. This also resolves the following Coccinelle warning: > > > > include/linux/fcntl.h:11:13-21: duplicated argument to & or | > > Now ask yourself what might be the reason for that "duplicated argument". > Try to figure out what the values of those constants might depend upon. > For extra points, try to guess what has caused the divergences. > > Please, post the result of your investigation in followup to this. I think the patch is actually right, despite the shockingly bad changelog. He's removed the duplicate 'O_NDELAY' and reformatted the lines.