From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50879C433E1 for ; Wed, 3 Jun 2020 05:53:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21ECB2068D for ; Wed, 3 Jun 2020 05:53:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fmJ7r4GA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725910AbgFCFwu (ORCPT ); Wed, 3 Jun 2020 01:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgFCFwp (ORCPT ); Wed, 3 Jun 2020 01:52:45 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55290C05BD1E; Tue, 2 Jun 2020 22:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=9xSJyTCnmOFnoeTw5DYF1pLBCTjN1a9aWOgqqyu87SA=; b=fmJ7r4GApABmWyYi50Df2Mbsxk YdvT5dRIM9PPbaEED6f8lLSZSY58sKEKwjxq+SxUDrp4P5qG5V0TSPFxNzfx7f7EYdUlhKVQYWQnl u0vmRyVQuXMbG84dX43uK/32+eRCvjSSk2kGuQoALO3aHRxE6l+bOW+6v9NqB09QcOqIC0MwQBLr9 CDkEfstsG4Gm5OC4Gu8VzpEVx60EGyyxHYeE3muDf6JYZQFZumn9wkKVA9cP6lvc63/3PcapccrLt INa1dn2cfNitFyq9IPKRm4Hrmu10EKbAK6HBZSksRGQad4Dg8aA0jeZaYuEILKNuh+Ca4K5QB6ar7 7jWY/LDQ==; Received: from p4fdb1ad2.dip0.t-ipconnect.de ([79.219.26.210] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgMKQ-0003na-Iy; Wed, 03 Jun 2020 05:52:43 +0000 From: Christoph Hellwig To: Alexander Viro Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, build test robot Subject: [PATCH 1/4] net/sysctl: use cpumask_parse in flow_limit_cpu_sysctl Date: Wed, 3 Jun 2020 07:52:34 +0200 Message-Id: <20200603055237.677416-2-hch@lst.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200603055237.677416-1-hch@lst.de> References: <20200603055237.677416-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org cpumask_parse_user works on __user pointers, so this is wrong now. Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") Reported-by: build test robot Signed-off-by: Christoph Hellwig --- net/core/sysctl_net_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 0ddb13a6282b0..d14d049af52ae 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -126,7 +126,7 @@ static int flow_limit_cpu_sysctl(struct ctl_table *table, int write, return -ENOMEM; if (write) { - ret = cpumask_parse_user(buffer, *lenp, mask); + ret = cpumask_parse(buffer, mask); if (ret) goto done; -- 2.26.2