From: Tom Hromatka <tom.hromatka@oracle.com>
To: tom.hromatka@oracle.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: fweisbec@gmail.com, tglx@linutronix.de, mingo@kernel.org,
adobriyan@gmail.com
Subject: [PATCH 2/2] /proc/stat: Simplify iowait and idle calculations when cpu is offline
Date: Wed, 10 Jun 2020 15:05:49 -0600 [thread overview]
Message-ID: <20200610210549.61193-3-tom.hromatka@oracle.com> (raw)
In-Reply-To: <20200610210549.61193-1-tom.hromatka@oracle.com>
A customer reported that when a cpu goes offline, the iowait and idle
times reported in /proc/stat will sometimes spike. This is being
caused by a different data source being used for these values when a
cpu is offline.
Prior to this patch:
put the system under heavy load so that there is little idle time
user nice system idle iowait
cpu 109515 17 32111 220686 607
take cpu1 offline
user nice system idle iowait
cpu 113742 17 32721 220724 612
bring cpu1 back online
user nice system idle iowait
cpu 118332 17 33430 220687 607
To prevent this, let's use the same data source whether a cpu is
online or not.
With this patch:
put the system under heavy load so that there is little idle time
user nice system idle iowait
cpu 14096 16 4646 157687 426
take cpu1 offline
user nice system idle iowait
cpu 21614 16 7179 157687 426
bring cpu1 back online
user nice system idle iowait
cpu 27362 16 9555 157688 426
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---
fs/proc/stat.c | 24 ++++++------------------
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/fs/proc/stat.c b/fs/proc/stat.c
index 46b3293015fe..35b92539e711 100644
--- a/fs/proc/stat.c
+++ b/fs/proc/stat.c
@@ -47,32 +47,20 @@ static u64 get_iowait_time(struct kernel_cpustat *kcs, int cpu)
static u64 get_idle_time(struct kernel_cpustat *kcs, int cpu)
{
- u64 idle, idle_usecs = -1ULL;
+ u64 idle, idle_usecs;
- if (cpu_online(cpu))
- idle_usecs = get_cpu_idle_time_us(cpu, NULL);
-
- if (idle_usecs == -1ULL)
- /* !NO_HZ or cpu offline so we can rely on cpustat.idle */
- idle = kcs->cpustat[CPUTIME_IDLE];
- else
- idle = idle_usecs * NSEC_PER_USEC;
+ idle_usecs = get_cpu_idle_time_us(cpu, NULL);
+ idle = idle_usecs * NSEC_PER_USEC;
return idle;
}
static u64 get_iowait_time(struct kernel_cpustat *kcs, int cpu)
{
- u64 iowait, iowait_usecs = -1ULL;
-
- if (cpu_online(cpu))
- iowait_usecs = get_cpu_iowait_time_us(cpu, NULL);
+ u64 iowait, iowait_usecs;
- if (iowait_usecs == -1ULL)
- /* !NO_HZ or cpu offline so we can rely on cpustat.iowait */
- iowait = kcs->cpustat[CPUTIME_IOWAIT];
- else
- iowait = iowait_usecs * NSEC_PER_USEC;
+ iowait_usecs = get_cpu_iowait_time_us(cpu, NULL);
+ iowait = iowait_usecs * NSEC_PER_USEC;
return iowait;
}
--
2.25.3
next prev parent reply other threads:[~2020-06-10 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 21:05 [PATCH 0/2] iowait and idle fixes in /proc/stat Tom Hromatka
2020-06-10 21:05 ` [PATCH 1/2] tick-sched: Do not clear the iowait and idle times Tom Hromatka
2020-06-10 21:05 ` Tom Hromatka [this message]
2020-07-14 18:55 ` [PATCH 0/2] iowait and idle fixes in /proc/stat Tom Hromatka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610210549.61193-3-tom.hromatka@oracle.com \
--to=tom.hromatka@oracle.com \
--cc=adobriyan@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).