From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz,
linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mm-commits@vger.kernel.org, Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH -mmotm] mm/memory-failure: remove stub function
Date: Thu, 2 Jul 2020 08:38:33 +1000 [thread overview]
Message-ID: <20200702083833.1f71c272@canb.auug.org.au> (raw)
In-Reply-To: <adb60490-484f-a154-e163-725e35a821dc@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
Hi Randy,
On Wed, 1 Jul 2020 08:47:30 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> This stub is no longer needed since the function is no longer
> inside an #ifdef/#endif block.
>
> Fixes this build error:
>
> ../mm/memory-failure.c:180:13: error: redefinition of ‘page_handle_poison’
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Oscar Salvador <osalvador@suse.de>
> ---
> mm/memory-failure.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> --- mmotm-2020-0630-2152.orig/mm/memory-failure.c
> +++ mmotm-2020-0630-2152/mm/memory-failure.c
> @@ -169,10 +169,6 @@ int hwpoison_filter(struct page *p)
> return 0;
> }
>
> -static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, bool release)
> -{
> - return true;
> -}
> #endif
>
> EXPORT_SYMBOL_GPL(hwpoison_filter);
Added to linux-next today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-07-01 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 4:53 mmotm 2020-06-30-21-52 uploaded akpm
2020-07-01 15:47 ` [PATCH -mmotm] mm/memory-failure: remove stub function Randy Dunlap
2020-07-01 22:38 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702083833.1f71c272@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).