From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=5by7=AO=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 72AEAC433E0
	for <linux-fsdevel@archiver.kernel.org>; Fri,  3 Jul 2020 01:34:51 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 587E8207E8
	for <linux-fsdevel@archiver.kernel.org>; Fri,  3 Jul 2020 01:34:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726568AbgGCBer (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Thu, 2 Jul 2020 21:34:47 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37262 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726017AbgGCBeq (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 2 Jul 2020 21:34:46 -0400
Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFE0BC08C5C1;
        Thu,  2 Jul 2020 18:34:46 -0700 (PDT)
Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jrAbB-004Hg1-8m; Fri, 03 Jul 2020 01:34:41 +0000
Date:   Fri, 3 Jul 2020 02:34:41 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 19/23] sysctl: Call sysctl_head_finish on error
Message-ID: <20200703013441.GR2786714@ZenIV.linux.org.uk>
References: <20200701200951.3603160-1-hch@lst.de>
 <20200701200951.3603160-20-hch@lst.de>
 <20200702003240.GW25523@casper.infradead.org>
 <20200702051512.GA30361@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200702051512.GA30361@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Thu, Jul 02, 2020 at 07:15:12AM +0200, Christoph Hellwig wrote:
> On Thu, Jul 02, 2020 at 01:32:40AM +0100, Matthew Wilcox wrote:
> > On Wed, Jul 01, 2020 at 10:09:47PM +0200, Christoph Hellwig wrote:
> > > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> > > 
> > > This error path returned directly instead of calling sysctl_head_finish().
> > > 
> > > Fixes: ef9d965bc8b6 ("sysctl: reject gigantic reads/write to sysctl files")
> > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > 
> > I think this one needs to go to Linus before 5.8, not get stuck in the
> > middle of a large patch series.
> 
> I've only kept it here because it didn't show up in Linus tree yet.
> If you send it and it gets picked up I can trivially drop it.

I'll send it tonight, if it's not there yet...